Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Side by Side Diff: Source/core/editing/VisibleSelection.h

Issue 1307763003: Get rid of VisibleSelection constructor with Range parameter (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/editing/Editor.cpp ('k') | Source/core/editing/VisibleSelection.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004 Apple Computer, Inc. All rights reserved. 2 * Copyright (C) 2004 Apple Computer, Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 80 matching lines...) Expand 10 before | Expand all | Expand 10 after
91 static PositionType toPositionType(const Position& position) { return to PositionInComposedTree(position); } 91 static PositionType toPositionType(const Position& position) { return to PositionInComposedTree(position); }
92 }; 92 };
93 93
94 VisibleSelection(); 94 VisibleSelection();
95 95
96 VisibleSelection(const Position&, TextAffinity, bool isDirectional = false); 96 VisibleSelection(const Position&, TextAffinity, bool isDirectional = false);
97 VisibleSelection(const Position& base, const Position& extent, TextAffinity = SEL_DEFAULT_AFFINITY, bool isDirectional = false); 97 VisibleSelection(const Position& base, const Position& extent, TextAffinity = SEL_DEFAULT_AFFINITY, bool isDirectional = false);
98 VisibleSelection(const PositionInComposedTree& base, const PositionInCompose dTree& extent, TextAffinity = SEL_DEFAULT_AFFINITY, bool isDirectional = false); 98 VisibleSelection(const PositionInComposedTree& base, const PositionInCompose dTree& extent, TextAffinity = SEL_DEFAULT_AFFINITY, bool isDirectional = false);
99 99
100 explicit VisibleSelection(const EphemeralRange&, TextAffinity = SEL_DEFAULT_ AFFINITY, bool isDirectional = false); 100 explicit VisibleSelection(const EphemeralRange&, TextAffinity = SEL_DEFAULT_ AFFINITY, bool isDirectional = false);
101 explicit VisibleSelection(const Range*, TextAffinity = SEL_DEFAULT_AFFINITY, bool isDirectional = false);
102 101
103 explicit VisibleSelection(const VisiblePosition&, bool isDirectional = false ); 102 explicit VisibleSelection(const VisiblePosition&, bool isDirectional = false );
104 VisibleSelection(const VisiblePosition&, const VisiblePosition&, bool isDire ctional = false); 103 VisibleSelection(const VisiblePosition&, const VisiblePosition&, bool isDire ctional = false);
105 104
106 VisibleSelection(const VisibleSelection&); 105 VisibleSelection(const VisibleSelection&);
107 VisibleSelection& operator=(const VisibleSelection&); 106 VisibleSelection& operator=(const VisibleSelection&);
108 107
109 static VisibleSelection selectionFromContentsOfNode(Node*); 108 static VisibleSelection selectionFromContentsOfNode(Node*);
110 109
111 SelectionType selectionType() const { return m_selectionType; } 110 SelectionType selectionType() const { return m_selectionType; }
(...skipping 148 matching lines...) Expand 10 before | Expand all | Expand 10 after
260 259
261 } // namespace blink 260 } // namespace blink
262 261
263 #ifndef NDEBUG 262 #ifndef NDEBUG
264 // Outside the WebCore namespace for ease of invocation from gdb. 263 // Outside the WebCore namespace for ease of invocation from gdb.
265 void showTree(const blink::VisibleSelection&); 264 void showTree(const blink::VisibleSelection&);
266 void showTree(const blink::VisibleSelection*); 265 void showTree(const blink::VisibleSelection*);
267 #endif 266 #endif
268 267
269 #endif // VisibleSelection_h 268 #endif // VisibleSelection_h
OLDNEW
« no previous file with comments | « Source/core/editing/Editor.cpp ('k') | Source/core/editing/VisibleSelection.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698