Source/core/editing/VisibleSelection.cpp - Issue 1307763003: Get rid of VisibleSelection constructor with Range parameter

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/editing/VisibleSelection.cpp

Issue 1307763003: Get rid of VisibleSelection constructor with Range parameter (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/editing/VisibleSelection.cpp

diff --git a/Source/core/editing/VisibleSelection.cpp b/Source/core/editing/VisibleSelection.cpp

index 2ef64380a1ca35dff680130a93f3d22e570d48cf..c45fcdb44722b3a242eecae3483c5ff32e0448d2 100644

--- a/Source/core/editing/VisibleSelection.cpp

+++ b/Source/core/editing/VisibleSelection.cpp

@@ -85,11 +85,6 @@ VisibleSelection::VisibleSelection(const EphemeralRange& range, TextAffinity aff

{

}

-VisibleSelection::VisibleSelection(const Range* range, TextAffinity affinity, bool isDirectional)

- : VisibleSelection(range->startPosition(), range->endPosition(), affinity, isDirectional)

VisibleSelection::VisibleSelection(const VisibleSelection& other)

: m_base(other.m_base)

, m_extent(other.m_extent)

« no previous file with comments | « Source/core/editing/VisibleSelection.h ('k') | Source/core/page/DragController.cpp » ('j') | no next file with comments »