Source/core/page/DragController.cpp - Issue 1307763003: Get rid of VisibleSelection constructor with Range parameter

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/page/DragController.cpp

Issue 1307763003: Get rid of VisibleSelection constructor with Range parameter (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/page/DragController.cpp

diff --git a/Source/core/page/DragController.cpp b/Source/core/page/DragController.cpp

index a3c6409ba4b7226dd5c9edf8f314c49f85ddecb8..cdf18316ae531ea2763829cbc36f0b5db7b6a042 100644

--- a/Source/core/page/DragController.cpp

+++ b/Source/core/page/DragController.cpp

@@ -716,7 +716,7 @@ static void prepareDataTransferForImageDrag(LocalFrame* source, DataTransfer* da

if (node->isContentRichlyEditable()) {

RefPtrWillBeRawPtr<Range> range = source->document()->createRange();

range->selectNode(node, ASSERT_NO_EXCEPTION);

- source->selection().setSelection(VisibleSelection(range.get()));

+ source->selection().setSelection(VisibleSelection(EphemeralRange(range.get())));

}

dataTransfer->declareAndWriteDragImage(node, !linkURL.isEmpty() ? linkURL : imageURL, label);

}

« no previous file with comments | « Source/core/editing/VisibleSelection.cpp ('k') | Source/web/WebLocalFrameImpl.cpp » ('j') | no next file with comments »