Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Side by Side Diff: Source/core/editing/VisibleSelection.cpp

Issue 1307763003: Get rid of VisibleSelection constructor with Range parameter (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/editing/VisibleSelection.h ('k') | Source/core/page/DragController.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2005, 2006 Apple Computer, Inc. All rights reserved. 2 * Copyright (C) 2004, 2005, 2006 Apple Computer, Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 67 matching lines...) Expand 10 before | Expand all | Expand 10 after
78 VisibleSelection::VisibleSelection(const VisiblePosition& base, const VisiblePos ition& extent, bool isDirectional) 78 VisibleSelection::VisibleSelection(const VisiblePosition& base, const VisiblePos ition& extent, bool isDirectional)
79 : VisibleSelection(base.deepEquivalent(), extent.deepEquivalent(), base.affi nity(), isDirectional) 79 : VisibleSelection(base.deepEquivalent(), extent.deepEquivalent(), base.affi nity(), isDirectional)
80 { 80 {
81 } 81 }
82 82
83 VisibleSelection::VisibleSelection(const EphemeralRange& range, TextAffinity aff inity, bool isDirectional) 83 VisibleSelection::VisibleSelection(const EphemeralRange& range, TextAffinity aff inity, bool isDirectional)
84 : VisibleSelection(range.startPosition(), range.endPosition(), affinity, isD irectional) 84 : VisibleSelection(range.startPosition(), range.endPosition(), affinity, isD irectional)
85 { 85 {
86 } 86 }
87 87
88 VisibleSelection::VisibleSelection(const Range* range, TextAffinity affinity, bo ol isDirectional)
89 : VisibleSelection(range->startPosition(), range->endPosition(), affinity, i sDirectional)
90 {
91 }
92
93 VisibleSelection::VisibleSelection(const VisibleSelection& other) 88 VisibleSelection::VisibleSelection(const VisibleSelection& other)
94 : m_base(other.m_base) 89 : m_base(other.m_base)
95 , m_extent(other.m_extent) 90 , m_extent(other.m_extent)
96 , m_start(other.m_start) 91 , m_start(other.m_start)
97 , m_end(other.m_end) 92 , m_end(other.m_end)
98 , m_baseInComposedTree(other.m_baseInComposedTree) 93 , m_baseInComposedTree(other.m_baseInComposedTree)
99 , m_extentInComposedTree(other.m_extentInComposedTree) 94 , m_extentInComposedTree(other.m_extentInComposedTree)
100 , m_startInComposedTree(other.m_startInComposedTree) 95 , m_startInComposedTree(other.m_startInComposedTree)
101 , m_endInComposedTree(other.m_endInComposedTree) 96 , m_endInComposedTree(other.m_endInComposedTree)
102 , m_affinity(other.m_affinity) 97 , m_affinity(other.m_affinity)
(...skipping 1149 matching lines...) Expand 10 before | Expand all | Expand 10 after
1252 sel.showTreeForThis(); 1247 sel.showTreeForThis();
1253 } 1248 }
1254 1249
1255 void showTree(const blink::VisibleSelection* sel) 1250 void showTree(const blink::VisibleSelection* sel)
1256 { 1251 {
1257 if (sel) 1252 if (sel)
1258 sel->showTreeForThis(); 1253 sel->showTreeForThis();
1259 } 1254 }
1260 1255
1261 #endif 1256 #endif
OLDNEW
« no previous file with comments | « Source/core/editing/VisibleSelection.h ('k') | Source/core/page/DragController.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698