Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Issue 1306653005: Revert of [Android] Don't use a device blacklist if one isn't provided. (Closed)

Created:
5 years, 3 months ago by RobertoCN
Modified:
5 years, 3 months ago
CC:
chromium-reviews, jbudorick+watch_chromium.org, klundberg+watch_chromium.org, yfriedman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Android] Don't use a device blacklist if one isn't provided. (patchset #1 id:1 of https://codereview.chromium.org/1314823011/ ) Reason for revert: Speculative revert, some builders (Nexus 5, 6 and 9 under chromium.gpu) are failing at the device status check step after this change due to: File "build/android/buildbot/bb_device_status_check.py", line 154, in blacklisting_device_status if not serial in blacklist.Read(): AttributeError: 'NoneType' object has no attribute 'Read' See http://build.chromium.org/p/chromium.gpu/builders/Android%20Debug%20%28Nexus%205%29/builds/2067 for example. Original issue's description: > [Android] Don't use a device blacklist if one isn't provided. > > BUG=517709 > > Committed: https://crrev.com/be5c91849d2196f97c7a4e0b3e90597c3f2b4c40 > Cr-Commit-Position: refs/heads/master@{#347473} TBR=rnephew@chromium.org,jbudorick@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=517709 Committed: https://crrev.com/0179090eb844b39ea55bd70e8e2202c4d3a81026 Cr-Commit-Position: refs/heads/master@{#347489}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -37 lines) Patch
M build/android/adb_install_apk.py View 1 chunk +6 lines, -3 lines 0 comments Download
M build/android/adb_reverse_forwarder.py View 1 chunk +5 lines, -3 lines 0 comments Download
M build/android/buildbot/bb_device_status_check.py View 1 chunk +5 lines, -3 lines 0 comments Download
M build/android/devil/android/device_blacklist.py View 2 chunks +22 lines, -5 lines 0 comments Download
M build/android/devil/android/device_utils.py View 1 chunk +5 lines, -1 line 0 comments Download
M build/android/enable_asserts.py View 1 chunk +4 lines, -3 lines 0 comments Download
M build/android/provision_devices.py View 1 chunk +5 lines, -3 lines 0 comments Download
M build/android/pylib/local/device/local_device_environment.py View 1 chunk +2 lines, -3 lines 0 comments Download
M build/android/screenshot.py View 1 chunk +4 lines, -3 lines 0 comments Download
M build/android/test_runner.py View 1 chunk +7 lines, -4 lines 0 comments Download
M build/android/tombstones.py View 1 chunk +4 lines, -3 lines 0 comments Download
M build/android/update_verification.py View 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
RobertoCN
Created Revert of [Android] Don't use a device blacklist if one isn't provided.
5 years, 3 months ago (2015-09-04 21:18:19 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1306653005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1306653005/1
5 years, 3 months ago (2015-09-04 21:18:49 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-04 21:19:39 UTC) #3
commit-bot: I haz the power
5 years, 3 months ago (2015-09-04 21:20:17 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0179090eb844b39ea55bd70e8e2202c4d3a81026
Cr-Commit-Position: refs/heads/master@{#347489}

Powered by Google App Engine
This is Rietveld 408576698