Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5118)

Unified Diff: build/android/test_runner.py

Issue 1306653005: Revert of [Android] Don't use a device blacklist if one isn't provided. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/android/screenshot.py ('k') | build/android/tombstones.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/test_runner.py
diff --git a/build/android/test_runner.py b/build/android/test_runner.py
index 18b87adec8993a4f364f7972908b2426291ac81b..204c81c0e6bbacd811d5d0af370fac233fbc2745 100755
--- a/build/android/test_runner.py
+++ b/build/android/test_runner.py
@@ -895,10 +895,13 @@
Returns:
A list of attached devices.
"""
- blacklist = (device_blacklist.Blacklist(blacklist_file)
- if blacklist_file
- else None)
-
+ if not blacklist_file:
+ # TODO(jbudorick): Remove this once bots pass the blacklist file.
+ blacklist_file = device_blacklist.BLACKLIST_JSON
+ logging.warning('Using default device blacklist %s',
+ device_blacklist.BLACKLIST_JSON)
+
+ blacklist = device_blacklist.Blacklist(blacklist_file)
attached_devices = device_utils.DeviceUtils.HealthyDevices(blacklist)
if test_device:
test_device = [d for d in attached_devices if d == test_device]
« no previous file with comments | « build/android/screenshot.py ('k') | build/android/tombstones.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698