Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Side by Side Diff: build/android/test_runner.py

Issue 1306653005: Revert of [Android] Don't use a device blacklist if one isn't provided. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « build/android/screenshot.py ('k') | build/android/tombstones.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 #!/usr/bin/env python 1 #!/usr/bin/env python
2 # 2 #
3 # Copyright 2013 The Chromium Authors. All rights reserved. 3 # Copyright 2013 The Chromium Authors. All rights reserved.
4 # Use of this source code is governed by a BSD-style license that can be 4 # Use of this source code is governed by a BSD-style license that can be
5 # found in the LICENSE file. 5 # found in the LICENSE file.
6 6
7 """Runs all types of tests from one unified interface.""" 7 """Runs all types of tests from one unified interface."""
8 8
9 import argparse 9 import argparse
10 import collections 10 import collections
(...skipping 877 matching lines...) Expand 10 before | Expand all | Expand 10 after
888 888
889 def _GetAttachedDevices(blacklist_file, test_device): 889 def _GetAttachedDevices(blacklist_file, test_device):
890 """Get all attached devices. 890 """Get all attached devices.
891 891
892 Args: 892 Args:
893 test_device: Name of a specific device to use. 893 test_device: Name of a specific device to use.
894 894
895 Returns: 895 Returns:
896 A list of attached devices. 896 A list of attached devices.
897 """ 897 """
898 blacklist = (device_blacklist.Blacklist(blacklist_file) 898 if not blacklist_file:
899 if blacklist_file 899 # TODO(jbudorick): Remove this once bots pass the blacklist file.
900 else None) 900 blacklist_file = device_blacklist.BLACKLIST_JSON
901 logging.warning('Using default device blacklist %s',
902 device_blacklist.BLACKLIST_JSON)
901 903
904 blacklist = device_blacklist.Blacklist(blacklist_file)
902 attached_devices = device_utils.DeviceUtils.HealthyDevices(blacklist) 905 attached_devices = device_utils.DeviceUtils.HealthyDevices(blacklist)
903 if test_device: 906 if test_device:
904 test_device = [d for d in attached_devices if d == test_device] 907 test_device = [d for d in attached_devices if d == test_device]
905 if not test_device: 908 if not test_device:
906 raise device_errors.DeviceUnreachableError( 909 raise device_errors.DeviceUnreachableError(
907 'Did not find device %s among attached device. Attached devices: %s' 910 'Did not find device %s among attached device. Attached devices: %s'
908 % (test_device, ', '.join(attached_devices))) 911 % (test_device, ', '.join(attached_devices)))
909 return test_device 912 return test_device
910 913
911 else: 914 else:
(...skipping 151 matching lines...) Expand 10 before | Expand all | Expand 10 after
1063 if e.is_infra_error: 1066 if e.is_infra_error:
1064 return constants.INFRA_EXIT_CODE 1067 return constants.INFRA_EXIT_CODE
1065 return constants.ERROR_EXIT_CODE 1068 return constants.ERROR_EXIT_CODE
1066 except: # pylint: disable=W0702 1069 except: # pylint: disable=W0702
1067 logging.exception('Unrecognized error occurred.') 1070 logging.exception('Unrecognized error occurred.')
1068 return constants.ERROR_EXIT_CODE 1071 return constants.ERROR_EXIT_CODE
1069 1072
1070 1073
1071 if __name__ == '__main__': 1074 if __name__ == '__main__':
1072 sys.exit(main()) 1075 sys.exit(main())
OLDNEW
« no previous file with comments | « build/android/screenshot.py ('k') | build/android/tombstones.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698