Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Side by Side Diff: build/android/tombstones.py

Issue 1306653005: Revert of [Android] Don't use a device blacklist if one isn't provided. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « build/android/test_runner.py ('k') | build/android/update_verification.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 #!/usr/bin/env python 1 #!/usr/bin/env python
2 # 2 #
3 # Copyright 2013 The Chromium Authors. All rights reserved. 3 # Copyright 2013 The Chromium Authors. All rights reserved.
4 # Use of this source code is governed by a BSD-style license that can be 4 # Use of this source code is governed by a BSD-style license that can be
5 # found in the LICENSE file. 5 # found in the LICENSE file.
6 # 6 #
7 # Find the most recent tombstone file(s) on all connected devices 7 # Find the most recent tombstone file(s) on all connected devices
8 # and prints their stacks. 8 # and prints their stacks.
9 # 9 #
10 # Assumes tombstone file was created with current symbols. 10 # Assumes tombstone file was created with current symbols.
(...skipping 219 matching lines...) Expand 10 before | Expand all | Expand 10 after
230 parser.add_option('-s', '--stack', action='store_true', 230 parser.add_option('-s', '--stack', action='store_true',
231 help='Also include symbols for stack data') 231 help='Also include symbols for stack data')
232 parser.add_option('-w', '--wipe-tombstones', action='store_true', 232 parser.add_option('-w', '--wipe-tombstones', action='store_true',
233 help='Erase all tombstones from device after processing') 233 help='Erase all tombstones from device after processing')
234 parser.add_option('-j', '--jobs', type='int', 234 parser.add_option('-j', '--jobs', type='int',
235 default=4, 235 default=4,
236 help='Number of jobs to use when processing multiple ' 236 help='Number of jobs to use when processing multiple '
237 'crash stacks.') 237 'crash stacks.')
238 options, _ = parser.parse_args() 238 options, _ = parser.parse_args()
239 239
240 blacklist = (device_blacklist.Blacklist(options.blacklist_file) 240 if options.blacklist_file:
241 if options.blacklist_file 241 blacklist = device_blacklist.Blacklist(options.blacklist_file)
242 else None) 242 else:
243 blacklist = None
243 244
244 if options.device: 245 if options.device:
245 devices = [device_utils.DeviceUtils(options.device)] 246 devices = [device_utils.DeviceUtils(options.device)]
246 else: 247 else:
247 devices = device_utils.DeviceUtils.HealthyDevices(blacklist) 248 devices = device_utils.DeviceUtils.HealthyDevices(blacklist)
248 249
249 # This must be done serially because strptime can hit a race condition if 250 # This must be done serially because strptime can hit a race condition if
250 # used for the first time in a multithreaded environment. 251 # used for the first time in a multithreaded environment.
251 # http://bugs.python.org/issue7980 252 # http://bugs.python.org/issue7980
252 tombstones = [] 253 tombstones = []
253 for device in devices: 254 for device in devices:
254 tombstones += _GetTombstonesForDevice(device, options) 255 tombstones += _GetTombstonesForDevice(device, options)
255 256
256 _ResolveTombstones(options.jobs, tombstones) 257 _ResolveTombstones(options.jobs, tombstones)
257 258
258 259
259 if __name__ == '__main__': 260 if __name__ == '__main__':
260 sys.exit(main()) 261 sys.exit(main())
OLDNEW
« no previous file with comments | « build/android/test_runner.py ('k') | build/android/update_verification.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698