Issue 129853005: Fix checkForRepaintDuringLayout do return false when doing repaintAfterLayout.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 129853005: Fix checkForRepaintDuringLayout do return false when doing repaintAfterLayout. (Closed)

Created:
6 years, 11 months ago by dsinclair

Modified:
6 years, 11 months ago

Reviewers:
ojan, eseidel, esprehn, Julien - ping for review

CC:
blink-reviews, bemjb+rendering_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, zoltan1

Base URL:
https://chromium.googlesource.com/chromium/blink@master

Visibility:
Public.

More Reviews

Description

Fix checkForRepaintDuringLayout do return false when doing repaintAfterLayout. The checkForRepaintDuringLayout is needed for both the non-repaintAfterLayout and the repaintAfterLayout case. So, I've split the method into checkForRepaint and checkForRepaintAfterLayout which are used as needed. This change pointed out a few missing LayoutRectRecorder entries that have been added to fixup LayoutTests. BUG=310398 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165101

Patch Set 1 #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+22 lines, -10 lines)			Patch
M	Source/core/rendering/RenderBlockFlow.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/rendering/RenderBlockLineLayout.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/rendering/RenderFlexibleBox.cpp	View	4 chunks	+7 lines, -1 line	0 comments	Download
M	Source/core/rendering/RenderFrameSet.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/rendering/RenderObject.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/core/rendering/RenderObject.cpp	View	1 chunk	+6 lines, -1 line	0 comments	Download
M	Source/core/rendering/RenderTableCell.cpp	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	Source/core/rendering/RenderTableRow.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/rendering/RenderTableSection.cpp	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	Source/core/rendering/RenderTextControlSingleLine.cpp	View	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dsinclair@chromium.org/129853005/1

6 years, 11 months ago (2014-01-14 18:39:11 UTC) #3

Message was sent while issue was closed.

Change committed as 165101

Expand Messages | Collapse Messages