Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Side by Side Diff: Source/core/rendering/RenderTableRow.cpp

Issue 129853005: Fix checkForRepaintDuringLayout do return false when doing repaintAfterLayout. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink@master
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/rendering/RenderTableCell.cpp ('k') | Source/core/rendering/RenderTableSection.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /** 1 /**
2 * Copyright (C) 1997 Martin Jones (mjones@kde.org) 2 * Copyright (C) 1997 Martin Jones (mjones@kde.org)
3 * (C) 1997 Torben Weis (weis@kde.org) 3 * (C) 1997 Torben Weis (weis@kde.org)
4 * (C) 1998 Waldo Bastian (bastian@kde.org) 4 * (C) 1998 Waldo Bastian (bastian@kde.org)
5 * (C) 1999 Lars Knoll (knoll@kde.org) 5 * (C) 1999 Lars Knoll (knoll@kde.org)
6 * (C) 1999 Antti Koivisto (koivisto@kde.org) 6 * (C) 1999 Antti Koivisto (koivisto@kde.org)
7 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All r ights reserved. 7 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All r ights reserved.
8 * 8 *
9 * This library is free software; you can redistribute it and/or 9 * This library is free software; you can redistribute it and/or
10 * modify it under the terms of the GNU Library General Public 10 * modify it under the terms of the GNU Library General Public
(...skipping 168 matching lines...) Expand 10 before | Expand all | Expand 10 after
179 cell->layout(); 179 cell->layout();
180 } 180 }
181 } 181 }
182 } 182 }
183 183
184 // We only ever need to repaint if our cells didn't, which means that they d idn't need 184 // We only ever need to repaint if our cells didn't, which means that they d idn't need
185 // layout, so we know that our bounds didn't change. This code is just makin g up for 185 // layout, so we know that our bounds didn't change. This code is just makin g up for
186 // the fact that we did not repaint in setStyle() because we had a layout hi nt. 186 // the fact that we did not repaint in setStyle() because we had a layout hi nt.
187 // We cannot call repaint() because our clippedOverflowRectForRepaint() is t aken from the 187 // We cannot call repaint() because our clippedOverflowRectForRepaint() is t aken from the
188 // parent table, and being mid-layout, that is invalid. Instead, we repaint our cells. 188 // parent table, and being mid-layout, that is invalid. Instead, we repaint our cells.
189 if (selfNeedsLayout() && checkForRepaintDuringLayout()) { 189 if (selfNeedsLayout() && checkForRepaint()) {
190 for (RenderObject* child = firstChild(); child; child = child->nextSibli ng()) { 190 for (RenderObject* child = firstChild(); child; child = child->nextSibli ng()) {
191 if (child->isTableCell()) { 191 if (child->isTableCell()) {
192 if (RuntimeEnabledFeatures::repaintAfterLayoutEnabled()) { 192 if (RuntimeEnabledFeatures::repaintAfterLayoutEnabled()) {
193 // FIXME: Is this needed with repaint After Layout? 193 // FIXME: Is this needed with repaint After Layout?
194 child->setShouldDoFullRepaintAfterLayout(true); 194 child->setShouldDoFullRepaintAfterLayout(true);
195 } else { 195 } else {
196 child->repaint(); 196 child->repaint();
197 } 197 }
198 } 198 }
199 } 199 }
(...skipping 85 matching lines...) Expand 10 before | Expand all | Expand 10 after
285 285
286 RenderTableRow* RenderTableRow::createAnonymousWithParentRenderer(const RenderOb ject* parent) 286 RenderTableRow* RenderTableRow::createAnonymousWithParentRenderer(const RenderOb ject* parent)
287 { 287 {
288 RenderTableRow* newRow = RenderTableRow::createAnonymous(&parent->document() ); 288 RenderTableRow* newRow = RenderTableRow::createAnonymous(&parent->document() );
289 RefPtr<RenderStyle> newStyle = RenderStyle::createAnonymousStyleWithDisplay( parent->style(), TABLE_ROW); 289 RefPtr<RenderStyle> newStyle = RenderStyle::createAnonymousStyleWithDisplay( parent->style(), TABLE_ROW);
290 newRow->setStyle(newStyle.release()); 290 newRow->setStyle(newStyle.release());
291 return newRow; 291 return newRow;
292 } 292 }
293 293
294 } // namespace WebCore 294 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/core/rendering/RenderTableCell.cpp ('k') | Source/core/rendering/RenderTableSection.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698