Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Side by Side Diff: Source/core/rendering/RenderObject.h

Issue 129853005: Fix checkForRepaintDuringLayout do return false when doing repaintAfterLayout. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink@master
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/rendering/RenderFrameSet.cpp ('k') | Source/core/rendering/RenderObject.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2000 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 2000 Lars Knoll (knoll@kde.org)
3 * (C) 2000 Antti Koivisto (koivisto@kde.org) 3 * (C) 2000 Antti Koivisto (koivisto@kde.org)
4 * (C) 2000 Dirk Mueller (mueller@kde.org) 4 * (C) 2000 Dirk Mueller (mueller@kde.org)
5 * (C) 2004 Allan Sandfeld Jensen (kde@carewolf.com) 5 * (C) 2004 Allan Sandfeld Jensen (kde@carewolf.com)
6 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2012 Apple Inc. All r ights reserved. 6 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2012 Apple Inc. All r ights reserved.
7 * Copyright (C) 2009 Google Inc. All rights reserved. 7 * Copyright (C) 2009 Google Inc. All rights reserved.
8 * 8 *
9 * This library is free software; you can redistribute it and/or 9 * This library is free software; you can redistribute it and/or
10 * modify it under the terms of the GNU Library General Public 10 * modify it under the terms of the GNU Library General Public
(...skipping 814 matching lines...) Expand 10 before | Expand all | Expand 10 after
825 825
826 // Repaint a specific subrectangle within a given object. The rect |r| is i n the object's coordinate space. 826 // Repaint a specific subrectangle within a given object. The rect |r| is i n the object's coordinate space.
827 void repaintRectangle(const LayoutRect&) const; 827 void repaintRectangle(const LayoutRect&) const;
828 828
829 // Repaint only if our old bounds and new bounds are different. The caller m ay pass in newBounds and newOutlineBox if they are known. 829 // Repaint only if our old bounds and new bounds are different. The caller m ay pass in newBounds and newOutlineBox if they are known.
830 bool repaintAfterLayoutIfNeeded(const RenderLayerModelObject* repaintContain er, bool wasSelfLayout, 830 bool repaintAfterLayoutIfNeeded(const RenderLayerModelObject* repaintContain er, bool wasSelfLayout,
831 const LayoutRect& oldBounds, const LayoutRect& oldOutlineBox, const Layo utRect* newBoundsPtr = 0, const LayoutRect* newOutlineBoxPtr = 0); 831 const LayoutRect& oldBounds, const LayoutRect& oldOutlineBox, const Layo utRect* newBoundsPtr = 0, const LayoutRect* newOutlineBoxPtr = 0);
832 832
833 virtual void repaintOverflow(); 833 virtual void repaintOverflow();
834 834
835 bool checkForRepaint() const;
835 bool checkForRepaintDuringLayout() const; 836 bool checkForRepaintDuringLayout() const;
836 837
837 // Returns the rect that should be repainted whenever this object changes. The rect is in the view's 838 // Returns the rect that should be repainted whenever this object changes. The rect is in the view's
838 // coordinate space. This method deals with outlines and overflow. 839 // coordinate space. This method deals with outlines and overflow.
839 LayoutRect absoluteClippedOverflowRect() const 840 LayoutRect absoluteClippedOverflowRect() const
840 { 841 {
841 return clippedOverflowRectForRepaint(0); 842 return clippedOverflowRectForRepaint(0);
842 } 843 }
843 IntRect pixelSnappedAbsoluteClippedOverflowRect() const; 844 IntRect pixelSnappedAbsoluteClippedOverflowRect() const;
844 virtual LayoutRect clippedOverflowRectForRepaint(const RenderLayerModelObjec t* repaintContainer) const; 845 virtual LayoutRect clippedOverflowRectForRepaint(const RenderLayerModelObjec t* repaintContainer) const;
(...skipping 582 matching lines...) Expand 10 before | Expand all | Expand 10 after
1427 void showTree(const WebCore::RenderObject*); 1428 void showTree(const WebCore::RenderObject*);
1428 void showLineTree(const WebCore::RenderObject*); 1429 void showLineTree(const WebCore::RenderObject*);
1429 void showRenderTree(const WebCore::RenderObject* object1); 1430 void showRenderTree(const WebCore::RenderObject* object1);
1430 // We don't make object2 an optional parameter so that showRenderTree 1431 // We don't make object2 an optional parameter so that showRenderTree
1431 // can be called from gdb easily. 1432 // can be called from gdb easily.
1432 void showRenderTree(const WebCore::RenderObject* object1, const WebCore::RenderO bject* object2); 1433 void showRenderTree(const WebCore::RenderObject* object1, const WebCore::RenderO bject* object2);
1433 1434
1434 #endif 1435 #endif
1435 1436
1436 #endif // RenderObject_h 1437 #endif // RenderObject_h
OLDNEW
« no previous file with comments | « Source/core/rendering/RenderFrameSet.cpp ('k') | Source/core/rendering/RenderObject.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698