Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Side by Side Diff: Source/core/rendering/RenderObject.cpp

Issue 129853005: Fix checkForRepaintDuringLayout do return false when doing repaintAfterLayout. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink@master
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/rendering/RenderObject.h ('k') | Source/core/rendering/RenderTableCell.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2000 Dirk Mueller (mueller@kde.org) 4 * (C) 2000 Dirk Mueller (mueller@kde.org)
5 * (C) 2004 Allan Sandfeld Jensen (kde@carewolf.com) 5 * (C) 2004 Allan Sandfeld Jensen (kde@carewolf.com)
6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2011 Apple Inc. All rights reserv ed. 6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2011 Apple Inc. All rights reserv ed.
7 * Copyright (C) 2009 Google Inc. All rights reserved. 7 * Copyright (C) 2009 Google Inc. All rights reserved.
8 * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/) 8 * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/)
9 * 9 *
10 * This library is free software; you can redistribute it and/or 10 * This library is free software; you can redistribute it and/or
(...skipping 1589 matching lines...) Expand 10 before | Expand all | Expand 10 after
1600 repaintUsingContainer(repaintContainer, pixelSnappedIntRect(bottomRe ct)); 1600 repaintUsingContainer(repaintContainer, pixelSnappedIntRect(bottomRe ct));
1601 } 1601 }
1602 } 1602 }
1603 return false; 1603 return false;
1604 } 1604 }
1605 1605
1606 void RenderObject::repaintOverflow() 1606 void RenderObject::repaintOverflow()
1607 { 1607 {
1608 } 1608 }
1609 1609
1610 bool RenderObject::checkForRepaint() const
1611 {
1612 return !document().view()->needsFullRepaint() && !hasLayer() && everHadLayou t();
1613 }
1614
1610 bool RenderObject::checkForRepaintDuringLayout() const 1615 bool RenderObject::checkForRepaintDuringLayout() const
1611 { 1616 {
1612 return !document().view()->needsFullRepaint() && !hasLayer() && everHadLayou t(); 1617 return !RuntimeEnabledFeatures::repaintAfterLayoutEnabled() && checkForRepai nt();
1613 } 1618 }
1614 1619
1615 LayoutRect RenderObject::rectWithOutlineForRepaint(const RenderLayerModelObject* repaintContainer, LayoutUnit outlineWidth) const 1620 LayoutRect RenderObject::rectWithOutlineForRepaint(const RenderLayerModelObject* repaintContainer, LayoutUnit outlineWidth) const
1616 { 1621 {
1617 LayoutRect r(clippedOverflowRectForRepaint(repaintContainer)); 1622 LayoutRect r(clippedOverflowRectForRepaint(repaintContainer));
1618 r.inflate(outlineWidth); 1623 r.inflate(outlineWidth);
1619 return r; 1624 return r;
1620 } 1625 }
1621 1626
1622 LayoutRect RenderObject::clippedOverflowRectForRepaint(const RenderLayerModelObj ect*) const 1627 LayoutRect RenderObject::clippedOverflowRectForRepaint(const RenderLayerModelObj ect*) const
(...skipping 1784 matching lines...) Expand 10 before | Expand all | Expand 10 after
3407 { 3412 {
3408 if (object1) { 3413 if (object1) {
3409 const WebCore::RenderObject* root = object1; 3414 const WebCore::RenderObject* root = object1;
3410 while (root->parent()) 3415 while (root->parent())
3411 root = root->parent(); 3416 root = root->parent();
3412 root->showRenderTreeAndMark(object1, "*", object2, "-", 0); 3417 root->showRenderTreeAndMark(object1, "*", object2, "-", 0);
3413 } 3418 }
3414 } 3419 }
3415 3420
3416 #endif 3421 #endif
OLDNEW
« no previous file with comments | « Source/core/rendering/RenderObject.h ('k') | Source/core/rendering/RenderTableCell.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698