Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 1298263002: Revert of "gpu: Nexus5 and ANGLE crashes with GL_TEXTURE_CUBE_MAP_NEGATIVE_X" (Closed)

Created:
5 years, 4 months ago by leviw_travelin_and_unemployed
Modified:
5 years, 4 months ago
Reviewers:
dshwang, no sievers
CC:
chromium-reviews, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of "gpu: Nexus5 and ANGLE crashes with GL_TEXTURE_CUBE_MAP_NEGATIVE_X" (patchset #1 id:1 of https://codereview.chromium.org/1290053004/ ) Reason for revert: Broke virtual/gpu/fast/canvas/quadraticCurveTo.xml on Linux MSAN http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpectations=true&tests=virtual%2Fgpu%2Ffast%2Fcanvas%2FquadraticCurveTo.xml Original issue's description: > Reland of "gpu: Nexus5 and ANGLE crashes with GL_TEXTURE_CUBE_MAP_NEGATIVE_X" > > Original CL: https://codereview.chromium.org/1280163004 > Revert: https://codereview.chromium.org/1293123002 > > Linux ATI drivers have a crash bug similar to Android's, so workaround ATI also. > > BUG=517548 > > Committed: https://crrev.com/383c134c011b52705e4f2cd8bed1e3303ba98729 > Cr-Commit-Position: refs/heads/master@{#343834} TBR=sievers@chromium.org,dongseong.hwang@intel.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=517548 Committed: https://crrev.com/992f0cc257cfc54806ce99032404e826f622fe39 Cr-Commit-Position: refs/heads/master@{#344017}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -225 lines) Patch
M gpu/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 1 chunk +3 lines, -1 line 0 comments Download
M gpu/command_buffer/service/texture_manager.h View 4 chunks +2 lines, -15 lines 0 comments Download
M gpu/command_buffer/service/texture_manager.cc View 2 chunks +0 lines, -42 lines 0 comments Download
D gpu/command_buffer/tests/gl_cube_map_texture_unittest.cc View 1 chunk +0 lines, -138 lines 0 comments Download
M gpu/config/gpu_driver_bug_list_json.cc View 2 chunks +1 line, -25 lines 0 comments Download
M gpu/config/gpu_driver_bug_workaround_type.h View 1 chunk +0 lines, -2 lines 0 comments Download
M gpu/gpu.gyp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
leviw_travelin_and_unemployed
Created Revert of "gpu: Nexus5 and ANGLE crashes with GL_TEXTURE_CUBE_MAP_NEGATIVE_X"
5 years, 4 months ago (2015-08-18 20:29:08 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1298263002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1298263002/1
5 years, 4 months ago (2015-08-18 20:29:31 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-18 20:30:31 UTC) #3
commit-bot: I haz the power
5 years, 4 months ago (2015-08-18 20:31:11 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/992f0cc257cfc54806ce99032404e826f622fe39
Cr-Commit-Position: refs/heads/master@{#344017}

Powered by Google App Engine
This is Rietveld 408576698