Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 1280163004: gpu: workaround force_cube_map_positive_x_allocation fixes Android crash. (Closed)

Created:
5 years, 4 months ago by dshwang
Modified:
5 years, 4 months ago
CC:
chromium-reviews, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

gpu: workaround force_cube_map_positive_x_allocation fixes Android crash. Adreno Android (e.g. Nexus5) crashes on allocating a cube map texture bound to FBO, if the CUBE_MAP_POSITIVE_X texture is not allocated yet. The Workaround forces to allocate the CUBE_MAP_POSITIVE_X texture. Add new unittests to prevent regression. ANGLE crashes on GLCubeMapTextureTest.ReadPixels It's will be fixed in ANGLE project. TEST=gl_tests.GLCubeMapTextureTests.* BUG=518889 Committed: https://crrev.com/1eebeac3e05c2035139c04226b34cef745cfd822 Cr-Commit-Position: refs/heads/master@{#343600}

Patch Set 1 #

Patch Set 2 : prefix DISABLED_ to land first #

Total comments: 8

Patch Set 3 : address comments #

Patch Set 4 : introduce android workaround #

Patch Set 5 : disable ReadPixels test in linux and mac due to NVIDIA #

Total comments: 3

Patch Set 6 : fix bug about cube incomplete fbo #

Total comments: 6

Patch Set 7 : resolve sievers's comments #

Patch Set 8 : fix nvidia bot failure #

Patch Set 9 : git cl format #

Total comments: 6

Patch Set 10 : resolve sievers's comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+221 lines, -6 lines) Patch
M gpu/BUILD.gn View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -0 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -3 lines 0 comments Download
M gpu/command_buffer/service/texture_manager.h View 1 2 3 4 5 6 7 8 9 4 chunks +15 lines, -2 lines 0 comments Download
M gpu/command_buffer/service/texture_manager.cc View 1 2 3 4 5 6 7 8 9 2 chunks +50 lines, -0 lines 0 comments Download
A gpu/command_buffer/tests/gl_cube_map_texture_unittest.cc View 1 2 3 4 5 6 7 8 9 1 chunk +138 lines, -0 lines 0 comments Download
M gpu/config/gpu_driver_bug_list_json.cc View 1 2 3 2 chunks +13 lines, -1 line 0 comments Download
M gpu/config/gpu_driver_bug_workaround_type.h View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M gpu/gpu.gyp View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 28 (5 generated)
dshwang
piman, could you review? Windows and Android trybot failed in https://codereview.chromium.org/1275773003/ due to this issue. ...
5 years, 4 months ago (2015-08-10 17:30:46 UTC) #2
dshwang
kbr, need lots of yak shaving to fix crbug.com/504773 It's entry point of yak shaving.
5 years, 4 months ago (2015-08-10 17:34:25 UTC) #5
dshwang
sievers, could you review because piman is ooo?
5 years, 4 months ago (2015-08-10 18:29:59 UTC) #7
no sievers
https://codereview.chromium.org/1280163004/diff/20001/gpu/command_buffer/tests/gl_cube_map_texture_unittest.cc File gpu/command_buffer/tests/gl_cube_map_texture_unittest.cc (right): https://codereview.chromium.org/1280163004/diff/20001/gpu/command_buffer/tests/gl_cube_map_texture_unittest.cc#newcode6 gpu/command_buffer/tests/gl_cube_map_texture_unittest.cc:6: #define GL_GLEXT_PROTOTYPES nit: we don't do that elsewhere, it ...
5 years, 4 months ago (2015-08-10 19:34:10 UTC) #8
dshwang
I resolved all comments. could you review again? https://codereview.chromium.org/1280163004/diff/20001/gpu/command_buffer/tests/gl_cube_map_texture_unittest.cc File gpu/command_buffer/tests/gl_cube_map_texture_unittest.cc (right): https://codereview.chromium.org/1280163004/diff/20001/gpu/command_buffer/tests/gl_cube_map_texture_unittest.cc#newcode6 gpu/command_buffer/tests/gl_cube_map_texture_unittest.cc:6: #define ...
5 years, 4 months ago (2015-08-11 06:28:53 UTC) #9
dshwang
Hi, I invented Android workaround in new patch set. Could you review again?
5 years, 4 months ago (2015-08-11 11:46:11 UTC) #10
Ken Russell (switch to Gerrit)
Dongseong, thanks for working on this. GLCubeMapTextureTests is failing in the Mac and Linux tryjobs.
5 years, 4 months ago (2015-08-11 16:57:31 UTC) #11
dshwang
On 2015/08/11 16:57:31, Ken Russell OOO-till-Aug-17 wrote: > Dongseong, thanks for working on this. > ...
5 years, 4 months ago (2015-08-11 18:00:09 UTC) #12
Ken Russell (switch to Gerrit)
https://codereview.chromium.org/1280163004/diff/80001/gpu/command_buffer/tests/gl_cube_map_texture_unittest.cc File gpu/command_buffer/tests/gl_cube_map_texture_unittest.cc (right): https://codereview.chromium.org/1280163004/diff/80001/gpu/command_buffer/tests/gl_cube_map_texture_unittest.cc#newcode73 gpu/command_buffer/tests/gl_cube_map_texture_unittest.cc:73: // incomplete. crbug.com/518889 I think this test is wrong. ...
5 years, 4 months ago (2015-08-11 18:17:49 UTC) #13
dshwang
I fix the test bug about binding FBO to incomplete cube texture. Let's see NVIDIA ...
5 years, 4 months ago (2015-08-11 19:15:43 UTC) #14
no sievers
https://codereview.chromium.org/1280163004/diff/100001/gpu/command_buffer/service/texture_manager.cc File gpu/command_buffer/service/texture_manager.cc (right): https://codereview.chromium.org/1280163004/diff/100001/gpu/command_buffer/service/texture_manager.cc#newcode1991 gpu/command_buffer/service/texture_manager.cc:1991: DoTexImageArguments positive_x_args = args; I don't think we should ...
5 years, 4 months ago (2015-08-11 21:07:39 UTC) #15
no sievers
https://codereview.chromium.org/1280163004/diff/100001/gpu/command_buffer/tests/gl_cube_map_texture_unittest.cc File gpu/command_buffer/tests/gl_cube_map_texture_unittest.cc (right): https://codereview.chromium.org/1280163004/diff/100001/gpu/command_buffer/tests/gl_cube_map_texture_unittest.cc#newcode116 gpu/command_buffer/tests/gl_cube_map_texture_unittest.cc:116: EXPECT_EQ(static_cast<GLenum>(GL_FRAMEBUFFER_COMPLETE), what about mipmaps? don't you have to set ...
5 years, 4 months ago (2015-08-11 21:08:54 UTC) #16
dshwang
Thank you for nice review. I addressed all comments. could you review again? https://codereview.chromium.org/1280163004/diff/100001/gpu/command_buffer/service/texture_manager.cc File ...
5 years, 4 months ago (2015-08-12 08:06:09 UTC) #17
no sievers
https://codereview.chromium.org/1280163004/diff/100001/gpu/command_buffer/service/texture_manager.cc File gpu/command_buffer/service/texture_manager.cc (right): https://codereview.chromium.org/1280163004/diff/100001/gpu/command_buffer/service/texture_manager.cc#newcode1991 gpu/command_buffer/service/texture_manager.cc:1991: DoTexImageArguments positive_x_args = args; On 2015/08/12 08:06:09, dshwang wrote: ...
5 years, 4 months ago (2015-08-12 18:54:05 UTC) #18
dshwang
https://codereview.chromium.org/1280163004/diff/100001/gpu/command_buffer/service/texture_manager.cc File gpu/command_buffer/service/texture_manager.cc (right): https://codereview.chromium.org/1280163004/diff/100001/gpu/command_buffer/service/texture_manager.cc#newcode1991 gpu/command_buffer/service/texture_manager.cc:1991: DoTexImageArguments positive_x_args = args; On 2015/08/12 18:54:05, sievers wrote: ...
5 years, 4 months ago (2015-08-13 09:12:35 UTC) #19
no sievers
https://codereview.chromium.org/1280163004/diff/160001/gpu/command_buffer/service/texture_manager.cc File gpu/command_buffer/service/texture_manager.cc (right): https://codereview.chromium.org/1280163004/diff/160001/gpu/command_buffer/service/texture_manager.cc#newcode1994 gpu/command_buffer/service/texture_manager.cc:1994: positive_x_args.pixels_size = 0; You actually have to get this ...
5 years, 4 months ago (2015-08-13 18:56:38 UTC) #20
dshwang
Thank you for reviewing. I addressed your concerns. could you review again? https://codereview.chromium.org/1280163004/diff/160001/gpu/command_buffer/service/texture_manager.cc File gpu/command_buffer/service/texture_manager.cc ...
5 years, 4 months ago (2015-08-14 06:22:56 UTC) #21
no sievers
On 2015/08/14 06:22:56, dshwang wrote: > Thank you for reviewing. I addressed your concerns. could ...
5 years, 4 months ago (2015-08-14 19:50:58 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1280163004/180001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1280163004/180001
5 years, 4 months ago (2015-08-16 05:57:29 UTC) #24
dshwang
On 2015/08/14 19:50:58, sievers wrote: > On 2015/08/14 06:22:56, dshwang wrote: > > Thank you ...
5 years, 4 months ago (2015-08-16 05:58:22 UTC) #25
commit-bot: I haz the power
Committed patchset #10 (id:180001)
5 years, 4 months ago (2015-08-16 08:11:08 UTC) #26
commit-bot: I haz the power
Patchset 10 (id:??) landed as https://crrev.com/1eebeac3e05c2035139c04226b34cef745cfd822 Cr-Commit-Position: refs/heads/master@{#343600}
5 years, 4 months ago (2015-08-16 08:11:45 UTC) #27
Jamie Madill
5 years, 4 months ago (2015-08-17 14:20:27 UTC) #28
Message was sent while issue was closed.
A revert of this CL (patchset #10 id:180001) has been created in
https://codereview.chromium.org/1293123002/ by jmadill@chromium.org.

The reason for reverting is: Causing failures on the Linux AMD GPU FYI bot.

[ RUN      ]
GLCubeMapTextureTests/GLCubeMapTextureTest.ReadPixelsFromIncompleteFBO/5
Received signal 11 SEGV_MAPERR 000000000058
#0 0x000000486a35 base::debug::(anonymous namespace)::StackDumpSignalHandler()
#1 0x7fe9b624ecb0 <unknown>
#2 0x7fe9b31f6b9e <unknown>
#3 0x7fe9b3209948 <unknown>
#4 0x7fe9b31d9d02 <unknown>
#5 0x7fe9b31d426e <unknown>
#6 0x7fe9b2fec29b <unknown>
#7 0x7fe9b268badd <unknown>
#8 0x0000005138c6 gpu::gles2::Framebuffer::GetStatus()
#9 0x000000537936 gpu::gles2::GLES2DecoderImpl::CheckFramebufferValid().

Powered by Google App Engine
This is Rietveld 408576698