Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 1290053004: Reland of "gpu: Nexus5 and ANGLE crashes with GL_TEXTURE_CUBE_MAP_NEGATIVE_X" (Closed)

Created:
5 years, 4 months ago by dshwang
Modified:
5 years, 4 months ago
Reviewers:
no sievers
CC:
chromium-reviews, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of "gpu: Nexus5 and ANGLE crashes with GL_TEXTURE_CUBE_MAP_NEGATIVE_X" Original CL: https://codereview.chromium.org/1280163004 Revert: https://codereview.chromium.org/1293123002 Linux ATI drivers have a crash bug similar to Android's, so workaround ATI also. BUG=517548 Committed: https://crrev.com/383c134c011b52705e4f2cd8bed1e3303ba98729 Cr-Commit-Position: refs/heads/master@{#343834}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+225 lines, -6 lines) Patch
M gpu/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 1 chunk +1 line, -3 lines 0 comments Download
M gpu/command_buffer/service/texture_manager.h View 4 chunks +15 lines, -2 lines 0 comments Download
M gpu/command_buffer/service/texture_manager.cc View 2 chunks +42 lines, -0 lines 0 comments Download
A gpu/command_buffer/tests/gl_cube_map_texture_unittest.cc View 1 chunk +138 lines, -0 lines 0 comments Download
M gpu/config/gpu_driver_bug_list_json.cc View 2 chunks +25 lines, -1 line 1 comment Download
M gpu/config/gpu_driver_bug_workaround_type.h View 1 chunk +2 lines, -0 lines 0 comments Download
M gpu/gpu.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (2 generated)
dshwang
sievers, could you review it again? I workaround ATI also because of similar crash to ...
5 years, 4 months ago (2015-08-17 15:00:04 UTC) #2
dshwang
https://codereview.chromium.org/1290053004/diff/1/gpu/config/gpu_driver_bug_list_json.cc File gpu/config/gpu_driver_bug_list_json.cc (right): https://codereview.chromium.org/1290053004/diff/1/gpu/config/gpu_driver_bug_list_json.cc#newcode1498 gpu/config/gpu_driver_bug_list_json.cc:1498: "id": 128, Only this part is different from https://codereview.chromium.org/1280163004/
5 years, 4 months ago (2015-08-17 15:01:01 UTC) #3
no sievers
On 2015/08/17 15:01:01, dshwang wrote: > https://codereview.chromium.org/1290053004/diff/1/gpu/config/gpu_driver_bug_list_json.cc > File gpu/config/gpu_driver_bug_list_json.cc (right): > > https://codereview.chromium.org/1290053004/diff/1/gpu/config/gpu_driver_bug_list_json.cc#newcode1498 > ...
5 years, 4 months ago (2015-08-17 18:09:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1290053004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1290053004/1
5 years, 4 months ago (2015-08-18 05:34:23 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-18 06:22:31 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/383c134c011b52705e4f2cd8bed1e3303ba98729 Cr-Commit-Position: refs/heads/master@{#343834}
5 years, 4 months ago (2015-08-18 06:23:47 UTC) #8
dshwang
ATI passed this test http://build.chromium.org/p/chromium.gpu.fyi/builders/Linux%20Release%20%28ATI%29/builds/40979
5 years, 4 months ago (2015-08-18 08:01:18 UTC) #9
leviw_travelin_and_unemployed
On 2015/08/18 at 08:01:18, dongseong.hwang wrote: > ATI passed this test > http://build.chromium.org/p/chromium.gpu.fyi/builders/Linux%20Release%20%28ATI%29/builds/40979 This appears ...
5 years, 4 months ago (2015-08-18 17:53:03 UTC) #10
leviw_travelin_and_unemployed
5 years, 4 months ago (2015-08-18 20:29:07 UTC) #11
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1298263002/ by leviw@chromium.org.

The reason for reverting is: Broke virtual/gpu/fast/canvas/quadraticCurveTo.xml
on Linux MSAN

http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpec....

Powered by Google App Engine
This is Rietveld 408576698