Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(408)

Issue 1293123002: Revert of gpu: workaround force_cube_map_positive_x_allocation fixes Android crash. (Closed)

Created:
5 years, 4 months ago by Jamie Madill
Modified:
5 years, 4 months ago
CC:
chromium-reviews, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of gpu: workaround force_cube_map_positive_x_allocation fixes Android crash. (patchset #10 id:180001 of https://codereview.chromium.org/1280163004/ ) Reason for revert: Causing failures on the Linux AMD GPU FYI bot. [ RUN ] GLCubeMapTextureTests/GLCubeMapTextureTest.ReadPixelsFromIncompleteFBO/5 Received signal 11 SEGV_MAPERR 000000000058 #0 0x000000486a35 base::debug::(anonymous namespace)::StackDumpSignalHandler() #1 0x7fe9b624ecb0 <unknown> #2 0x7fe9b31f6b9e <unknown> #3 0x7fe9b3209948 <unknown> #4 0x7fe9b31d9d02 <unknown> #5 0x7fe9b31d426e <unknown> #6 0x7fe9b2fec29b <unknown> #7 0x7fe9b268badd <unknown> #8 0x0000005138c6 gpu::gles2::Framebuffer::GetStatus() #9 0x000000537936 gpu::gles2::GLES2DecoderImpl::CheckFramebufferValid() Original issue's description: > gpu: workaround force_cube_map_positive_x_allocation fixes Android crash. > > Adreno Android (e.g. Nexus5) crashes on allocating a cube map texture bound to FBO, if > the CUBE_MAP_POSITIVE_X texture is not allocated yet. The Workaround forces to allocate > the CUBE_MAP_POSITIVE_X texture. > > Add new unittests to prevent regression. ANGLE crashes on GLCubeMapTextureTest.ReadPixels > It's will be fixed in ANGLE project. > > TEST=gl_tests.GLCubeMapTextureTests.* > BUG=518889 > > Committed: https://crrev.com/1eebeac3e05c2035139c04226b34cef745cfd822 > Cr-Commit-Position: refs/heads/master@{#343600} TBR=piman@chromium.org,zmo@google.com,kbr@chromium.org,sievers@chromium.org,dongseong.hwang@intel.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=518889 Committed: https://crrev.com/a814ea088d8c8f85485b3588996605767081cd79 Cr-Commit-Position: refs/heads/master@{#343676}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -221 lines) Patch
M gpu/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 1 chunk +3 lines, -1 line 0 comments Download
M gpu/command_buffer/service/texture_manager.h View 4 chunks +2 lines, -15 lines 0 comments Download
M gpu/command_buffer/service/texture_manager.cc View 2 chunks +0 lines, -50 lines 0 comments Download
D gpu/command_buffer/tests/gl_cube_map_texture_unittest.cc View 1 chunk +0 lines, -138 lines 0 comments Download
M gpu/config/gpu_driver_bug_list_json.cc View 2 chunks +1 line, -13 lines 0 comments Download
M gpu/config/gpu_driver_bug_workaround_type.h View 1 chunk +0 lines, -2 lines 0 comments Download
M gpu/gpu.gyp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Jamie Madill
Created Revert of gpu: workaround force_cube_map_positive_x_allocation fixes Android crash.
5 years, 4 months ago (2015-08-17 14:20:28 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1293123002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1293123002/1
5 years, 4 months ago (2015-08-17 14:20:32 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-17 14:20:57 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/a814ea088d8c8f85485b3588996605767081cd79 Cr-Commit-Position: refs/heads/master@{#343676}
5 years, 4 months ago (2015-08-17 14:21:48 UTC) #4
dshwang
5 years, 4 months ago (2015-08-17 14:58:15 UTC) #5
Message was sent while issue was closed.
On 2015/08/17 14:20:28, Jamie Madill wrote:
> Created Revert of gpu: workaround force_cube_map_positive_x_allocation fixes
> Android crash.

Thank you for reverting it. Surprisingly ATI has similar crash bug to Android.
Let me workaround ATI also.

Powered by Google App Engine
This is Rietveld 408576698