Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(779)

Issue 128973003: Update bindings classes to use OVERRIDE / FINAL when needed (Closed)

Created:
6 years, 11 months ago by Inactive
Modified:
6 years, 11 months ago
CC:
blink-reviews, Nils Barth (inactive), kojih, arv+blink, jsbell+bindings_chromium.org, sof, abarth-chromium, marja+watch_chromium.org, dglazkov+blink, dominicc+watchlist_chromium.org, adamk+blink_chromium.org, Nate Chapin
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Update bindings classes to use OVERRIDE / FINAL when needed Update bindings classes to use OVERRIDE / FINAL when needed. Those are useful for error checking or performance when the compiler supports it. R=esprehn, abarth, haraken BUG=None Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=164739

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -68 lines) Patch
M Source/bindings/v8/CallbackPromiseAdapter.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/ExceptionState.h View 1 chunk +8 lines, -8 lines 0 comments Download
M Source/bindings/v8/ExceptionStatePlaceholder.h View 2 chunks +8 lines, -8 lines 0 comments Download
M Source/bindings/v8/PageScriptDebugServer.h View 2 chunks +11 lines, -11 lines 0 comments Download
M Source/bindings/v8/RetainedDOMInfo.h View 1 chunk +8 lines, -8 lines 0 comments Download
M Source/bindings/v8/ScriptObject.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/v8/ScriptString.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/V8AbstractEventListener.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/v8/V8CustomElementLifecycleCallbacks.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/V8ErrorHandler.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/bindings/v8/V8EventListener.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/V8LazyEventListener.h View 1 chunk +5 lines, -5 lines 0 comments Download
M Source/bindings/v8/V8MutationCallback.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/V8NodeFilterCondition.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/v8/V8StringResource.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/v8/V8WorkerGlobalScopeEventListener.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/bindings/v8/WorkerScriptDebugServer.h View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/bindings/v8/custom/V8ArrayBufferCustom.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/v8/custom/V8CustomXPathNSResolver.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/custom/V8PromiseCustom.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Inactive
6 years, 11 months ago (2014-01-08 21:53:15 UTC) #1
haraken
LGTM
6 years, 11 months ago (2014-01-08 22:58:05 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/128973003/1
6 years, 11 months ago (2014-01-08 23:51:02 UTC) #3
commit-bot: I haz the power
Change committed as 164739
6 years, 11 months ago (2014-01-09 04:04:51 UTC) #4
marja
Curious: what's the perf benefit of OVERRIDE or FINAL? I know there's the error checking ...
6 years, 11 months ago (2014-01-09 14:25:06 UTC) #5
Inactive
On 2014/01/09 14:25:06, marja wrote: > Curious: what's the perf benefit of OVERRIDE or FINAL? ...
6 years, 11 months ago (2014-01-09 14:36:17 UTC) #6
marja
6 years, 11 months ago (2014-01-09 15:21:55 UTC) #7
Message was sent while issue was closed.
k, good to know, thx.

Powered by Google App Engine
This is Rietveld 408576698