Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Unified Diff: Source/bindings/v8/V8LazyEventListener.h

Issue 128973003: Update bindings classes to use OVERRIDE / FINAL when needed (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/v8/V8EventListener.h ('k') | Source/bindings/v8/V8MutationCallback.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/v8/V8LazyEventListener.h
diff --git a/Source/bindings/v8/V8LazyEventListener.h b/Source/bindings/v8/V8LazyEventListener.h
index 4bc040ff95b1ca2dc3a9e43650054cfa7309ba3e..f86e01c0f138e4d93591ee12b052162c00b11e8a 100644
--- a/Source/bindings/v8/V8LazyEventListener.h
+++ b/Source/bindings/v8/V8LazyEventListener.h
@@ -46,28 +46,28 @@ namespace WebCore {
// V8LazyEventListener is a wrapper for a JavaScript code string that is compiled and evaluated when an event is fired.
// A V8LazyEventListener is either a HTML or SVG event handler.
- class V8LazyEventListener : public V8AbstractEventListener {
+ class V8LazyEventListener FINAL : public V8AbstractEventListener {
public:
static PassRefPtr<V8LazyEventListener> create(const AtomicString& functionName, const AtomicString& eventParameterName, const String& code, const String& sourceURL, const TextPosition& position, Node* node, v8::Isolate* isolate)
{
return adoptRef(new V8LazyEventListener(functionName, eventParameterName, code, sourceURL, position, node, isolate));
}
- virtual bool isLazy() const { return true; }
+ virtual bool isLazy() const OVERRIDE { return true; }
protected:
- virtual void prepareListenerObject(ExecutionContext*);
+ virtual void prepareListenerObject(ExecutionContext*) OVERRIDE;
private:
V8LazyEventListener(const AtomicString& functionName, const AtomicString& eventParameterName, const String& code, const String sourceURL, const TextPosition&, Node*, v8::Isolate*);
- virtual v8::Local<v8::Value> callListenerFunction(ExecutionContext*, v8::Handle<v8::Value> jsEvent, Event*);
+ virtual v8::Local<v8::Value> callListenerFunction(ExecutionContext*, v8::Handle<v8::Value> jsEvent, Event*) OVERRIDE;
// Needs to return true for all event handlers implemented in JavaScript so that
// the SVG code does not add the event handler in both
// SVGUseElement::buildShadowTree and again in
// SVGUseElement::transferEventListenersToShadowTree
- virtual bool wasCreatedFromMarkup() const { return true; }
+ virtual bool wasCreatedFromMarkup() const OVERRIDE { return true; }
AtomicString m_functionName;
AtomicString m_eventParameterName;
« no previous file with comments | « Source/bindings/v8/V8EventListener.h ('k') | Source/bindings/v8/V8MutationCallback.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698