Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Unified Diff: Source/bindings/v8/V8ErrorHandler.h

Issue 128973003: Update bindings classes to use OVERRIDE / FINAL when needed (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/v8/V8CustomElementLifecycleCallbacks.h ('k') | Source/bindings/v8/V8EventListener.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/v8/V8ErrorHandler.h
diff --git a/Source/bindings/v8/V8ErrorHandler.h b/Source/bindings/v8/V8ErrorHandler.h
index cfaa69de587baa8562a21fd84356c1ca28845a67..8412e418268dcb049dcc098abba66dca843ce678 100644
--- a/Source/bindings/v8/V8ErrorHandler.h
+++ b/Source/bindings/v8/V8ErrorHandler.h
@@ -40,7 +40,7 @@ namespace WebCore {
class ErrorEvent;
class Frame;
-class V8ErrorHandler : public V8EventListener {
+class V8ErrorHandler FINAL : public V8EventListener {
public:
static PassRefPtr<V8ErrorHandler> create(v8::Local<v8::Object> listener, bool isInline, v8::Isolate* isolate)
{
@@ -52,8 +52,8 @@ public:
private:
V8ErrorHandler(v8::Local<v8::Object> listener, bool isInline, v8::Isolate*);
- virtual v8::Local<v8::Value> callListenerFunction(ExecutionContext*, v8::Handle<v8::Value> jsEvent, Event*);
- virtual bool shouldPreventDefault(v8::Local<v8::Value> returnValue);
+ virtual v8::Local<v8::Value> callListenerFunction(ExecutionContext*, v8::Handle<v8::Value> jsEvent, Event*) OVERRIDE;
+ virtual bool shouldPreventDefault(v8::Local<v8::Value> returnValue) OVERRIDE;
};
} // namespace WebCore
« no previous file with comments | « Source/bindings/v8/V8CustomElementLifecycleCallbacks.h ('k') | Source/bindings/v8/V8EventListener.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698