Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Side by Side Diff: Source/bindings/v8/V8MutationCallback.h

Issue 128973003: Update bindings classes to use OVERRIDE / FINAL when needed (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/bindings/v8/V8LazyEventListener.h ('k') | Source/bindings/v8/V8NodeFilterCondition.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 21 matching lines...) Expand all
32 #include "bindings/v8/V8Utilities.h" 32 #include "bindings/v8/V8Utilities.h"
33 #include "core/dom/MutationCallback.h" 33 #include "core/dom/MutationCallback.h"
34 #include "wtf/OwnPtr.h" 34 #include "wtf/OwnPtr.h"
35 #include "wtf/RefPtr.h" 35 #include "wtf/RefPtr.h"
36 #include <v8.h> 36 #include <v8.h>
37 37
38 namespace WebCore { 38 namespace WebCore {
39 39
40 class ExecutionContext; 40 class ExecutionContext;
41 41
42 class V8MutationCallback : public MutationCallback, public ActiveDOMCallback { 42 class V8MutationCallback FINAL : public MutationCallback, public ActiveDOMCallba ck {
43 public: 43 public:
44 static PassOwnPtr<V8MutationCallback> create(v8::Handle<v8::Function> callba ck, ExecutionContext* context, v8::Handle<v8::Object> owner, v8::Isolate* isolat e) 44 static PassOwnPtr<V8MutationCallback> create(v8::Handle<v8::Function> callba ck, ExecutionContext* context, v8::Handle<v8::Object> owner, v8::Isolate* isolat e)
45 { 45 {
46 ASSERT(context); 46 ASSERT(context);
47 return adoptPtr(new V8MutationCallback(callback, context, owner, isolate )); 47 return adoptPtr(new V8MutationCallback(callback, context, owner, isolate ));
48 } 48 }
49 49
50 virtual void call(const Vector<RefPtr<MutationRecord> >&, MutationObserver*) OVERRIDE; 50 virtual void call(const Vector<RefPtr<MutationRecord> >&, MutationObserver*) OVERRIDE;
51 virtual ExecutionContext* executionContext() const OVERRIDE { return Context LifecycleObserver::executionContext(); } 51 virtual ExecutionContext* executionContext() const OVERRIDE { return Context LifecycleObserver::executionContext(); }
52 52
53 private: 53 private:
54 V8MutationCallback(v8::Handle<v8::Function>, ExecutionContext*, v8::Handle<v 8::Object>, v8::Isolate*); 54 V8MutationCallback(v8::Handle<v8::Function>, ExecutionContext*, v8::Handle<v 8::Object>, v8::Isolate*);
55 55
56 static void setWeakCallback(const v8::WeakCallbackData<v8::Function, V8Mutat ionCallback>&); 56 static void setWeakCallback(const v8::WeakCallbackData<v8::Function, V8Mutat ionCallback>&);
57 57
58 ScopedPersistent<v8::Function> m_callback; 58 ScopedPersistent<v8::Function> m_callback;
59 RefPtr<DOMWrapperWorld> m_world; 59 RefPtr<DOMWrapperWorld> m_world;
60 v8::Isolate* m_isolate; 60 v8::Isolate* m_isolate;
61 }; 61 };
62 62
63 } 63 }
64 64
65 #endif // V8MutationCallback_h 65 #endif // V8MutationCallback_h
OLDNEW
« no previous file with comments | « Source/bindings/v8/V8LazyEventListener.h ('k') | Source/bindings/v8/V8NodeFilterCondition.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698