Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Unified Diff: Source/bindings/v8/ExceptionState.h

Issue 128973003: Update bindings classes to use OVERRIDE / FINAL when needed (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/v8/CallbackPromiseAdapter.h ('k') | Source/bindings/v8/ExceptionStatePlaceholder.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/v8/ExceptionState.h
diff --git a/Source/bindings/v8/ExceptionState.h b/Source/bindings/v8/ExceptionState.h
index cfca25f4b4980a8093fde9104572b73ec0f8e904..5235318a8fbdbdd48509d1fe75d50c0191838052 100644
--- a/Source/bindings/v8/ExceptionState.h
+++ b/Source/bindings/v8/ExceptionState.h
@@ -127,21 +127,21 @@ private:
};
// Used if exceptions can/should not be directly thrown.
-class NonThrowableExceptionState : public ExceptionState {
+class NonThrowableExceptionState FINAL : public ExceptionState {
public:
NonThrowableExceptionState(): ExceptionState(v8::Handle<v8::Object>(), v8::Isolate::GetCurrent()) { }
- virtual void throwDOMException(const ExceptionCode&, const String& message) OVERRIDE FINAL;
- virtual void throwTypeError(const String& message = String()) OVERRIDE FINAL;
- virtual void throwSecurityError(const String& sanitizedMessage, const String& unsanitizedMessage = String()) OVERRIDE FINAL;
+ virtual void throwDOMException(const ExceptionCode&, const String& message) OVERRIDE;
+ virtual void throwTypeError(const String& message = String()) OVERRIDE;
+ virtual void throwSecurityError(const String& sanitizedMessage, const String& unsanitizedMessage = String()) OVERRIDE;
};
// Used if any exceptions thrown are ignorable.
-class TrackExceptionState : public ExceptionState {
+class TrackExceptionState FINAL : public ExceptionState {
public:
TrackExceptionState(): ExceptionState(v8::Handle<v8::Object>(), v8::Isolate::GetCurrent()) { }
- virtual void throwDOMException(const ExceptionCode&, const String& message) OVERRIDE FINAL;
- virtual void throwTypeError(const String& message = String()) OVERRIDE FINAL;
- virtual void throwSecurityError(const String& sanitizedMessage, const String& unsanitizedMessage = String()) OVERRIDE FINAL;
+ virtual void throwDOMException(const ExceptionCode&, const String& message) OVERRIDE;
+ virtual void throwTypeError(const String& message = String()) OVERRIDE;
+ virtual void throwSecurityError(const String& sanitizedMessage, const String& unsanitizedMessage = String()) OVERRIDE;
};
} // namespace WebCore
« no previous file with comments | « Source/bindings/v8/CallbackPromiseAdapter.h ('k') | Source/bindings/v8/ExceptionStatePlaceholder.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698