Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 1286043004: Make GrVertexBatch objects hold their own draws during GrDrawTarget flush (Closed)

Created:
5 years, 4 months ago by bsalomon
Modified:
5 years, 4 months ago
Reviewers:
joshualitt
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@m
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Make GrVertexBatch objects hold their own draws during GrDrawTarget flush NO_MERGE_BUILDS Committed: https://skia.googlesource.com/skia/+/7539856c1b9cbb1886a6a498cc534b77fc83ddb2

Patch Set 1 #

Patch Set 2 : update #

Patch Set 3 : update #

Patch Set 4 : update #

Total comments: 1

Patch Set 5 : rebase #

Patch Set 6 : Address warning #

Patch Set 7 : forward declare buffered draw target #

Patch Set 8 : forward decl #

Unified diffs Side-by-side diffs Delta from patch set Stats (+616 lines, -571 lines) Patch
M gm/beziereffects.cpp View 1 5 chunks +7 lines, -7 lines 0 comments Download
M gm/convexpolyeffect.cpp View 1 3 chunks +4 lines, -4 lines 0 comments Download
M gyp/gpu.gypi View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/gpu/GrAAConvexPathRenderer.cpp View 1 10 chunks +13 lines, -14 lines 0 comments Download
M src/gpu/GrAADistanceFieldPathRenderer.cpp View 1 11 chunks +20 lines, -20 lines 0 comments Download
M src/gpu/GrAAHairLinePathRenderer.cpp View 1 10 chunks +17 lines, -17 lines 0 comments Download
M src/gpu/GrAALinearizingConvexPathRenderer.cpp View 1 8 chunks +11 lines, -11 lines 0 comments Download
M src/gpu/GrAtlasTextContext.cpp View 1 8 chunks +17 lines, -20 lines 0 comments Download
M src/gpu/GrBatchAtlas.h View 5 chunks +5 lines, -6 lines 0 comments Download
M src/gpu/GrBatchAtlas.cpp View 1 11 chunks +24 lines, -26 lines 0 comments Download
A src/gpu/GrBatchFlushState.h View 1 2 3 1 chunk +189 lines, -0 lines 0 comments Download
A src/gpu/GrBatchFlushState.cpp View 1 1 chunk +31 lines, -0 lines 0 comments Download
M src/gpu/GrBatchFontCache.h View 1 3 chunks +6 lines, -7 lines 0 comments Download
M src/gpu/GrBatchFontCache.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/GrBatchTarget.h View 1 1 chunk +0 lines, -168 lines 0 comments Download
M src/gpu/GrBatchTarget.cpp View 1 1 chunk +0 lines, -64 lines 0 comments Download
M src/gpu/GrBufferedDrawTarget.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrCommandBuilder.h View 1 2 3 4 5 6 3 chunks +4 lines, -4 lines 0 comments Download
M src/gpu/GrCommandBuilder.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/gpu/GrContext.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrDefaultPathRenderer.cpp View 1 6 chunks +9 lines, -9 lines 0 comments Download
M src/gpu/GrImmediateDrawTarget.h View 1 2 chunks +1 line, -2 lines 0 comments Download
M src/gpu/GrImmediateDrawTarget.cpp View 3 chunks +4 lines, -6 lines 0 comments Download
M src/gpu/GrInOrderCommandBuilder.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrInOrderCommandBuilder.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrOvalRenderer.cpp View 1 17 chunks +23 lines, -23 lines 0 comments Download
M src/gpu/GrReorderCommandBuilder.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrReorderCommandBuilder.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrTargetCommands.h View 1 2 3 4 5 11 chunks +17 lines, -25 lines 0 comments Download
M src/gpu/GrTargetCommands.cpp View 1 2 chunks +31 lines, -36 lines 0 comments Download
M src/gpu/GrTessellatingPathRenderer.cpp View 1 4 chunks +5 lines, -5 lines 0 comments Download
M src/gpu/batches/GrAAFillRectBatch.cpp View 1 2 3 4 4 chunks +6 lines, -6 lines 0 comments Download
M src/gpu/batches/GrAAStrokeRectBatch.h View 2 chunks +4 lines, -2 lines 0 comments Download
M src/gpu/batches/GrAAStrokeRectBatch.cpp View 1 5 chunks +6 lines, -5 lines 0 comments Download
M src/gpu/batches/GrBWFillRectBatch.cpp View 1 4 chunks +6 lines, -6 lines 0 comments Download
M src/gpu/batches/GrDrawAtlasBatch.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/gpu/batches/GrDrawAtlasBatch.cpp View 1 4 chunks +5 lines, -4 lines 0 comments Download
M src/gpu/batches/GrDrawBatch.h View 2 chunks +28 lines, -2 lines 0 comments Download
M src/gpu/batches/GrDrawVerticesBatch.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/batches/GrDrawVerticesBatch.cpp View 1 5 chunks +7 lines, -7 lines 0 comments Download
M src/gpu/batches/GrStrokeRectBatch.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/gpu/batches/GrStrokeRectBatch.cpp View 1 5 chunks +5 lines, -6 lines 0 comments Download
M src/gpu/batches/GrTestBatch.h View 1 4 chunks +7 lines, -8 lines 0 comments Download
M src/gpu/batches/GrVertexBatch.h View 1 3 chunks +32 lines, -15 lines 0 comments Download
M src/gpu/batches/GrVertexBatch.cpp View 1 2 2 chunks +47 lines, -12 lines 0 comments Download
M src/gpu/effects/GrDashingEffect.cpp View 1 5 chunks +5 lines, -5 lines 0 comments Download
M tests/GrPorterDuffTest.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (9 generated)
bsalomon
5 years, 4 months ago (2015-08-17 18:28:02 UTC) #2
bsalomon
The onPrepareDraws should be moved to private in the subclasses, but deferring that to another ...
5 years, 4 months ago (2015-08-17 18:29:32 UTC) #3
joshualitt
nit, lgtm https://codereview.chromium.org/1286043004/diff/60001/src/gpu/batches/GrVertexBatch.cpp File src/gpu/batches/GrVertexBatch.cpp (right): https://codereview.chromium.org/1286043004/diff/60001/src/gpu/batches/GrVertexBatch.cpp#newcode68 src/gpu/batches/GrVertexBatch.cpp:68: for (SkTLList<DrawArray>::Iter da(fDrawArrays); da.get(); da.next()) { const_iter ...
5 years, 4 months ago (2015-08-17 18:52:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1286043004/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1286043004/80001
5 years, 4 months ago (2015-08-17 18:59:56 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1286043004/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1286043004/100001
5 years, 4 months ago (2015-08-17 19:02:41 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: Build-Mac10.8-Clang-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Mac10.8-Clang-x86_64-Release-Trybot/builds/5083) Build-Ubuntu-GCC-Arm64-Debug-Android-Trybot on client.skia.compile (JOB_FAILED, ...
5 years, 4 months ago (2015-08-17 19:03:50 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1286043004/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1286043004/140001
5 years, 4 months ago (2015-08-17 19:48:40 UTC) #16
commit-bot: I haz the power
5 years, 4 months ago (2015-08-17 19:55:43 UTC) #17
Message was sent while issue was closed.
Committed patchset #8 (id:140001) as
https://skia.googlesource.com/skia/+/7539856c1b9cbb1886a6a498cc534b77fc83ddb2

Powered by Google App Engine
This is Rietveld 408576698