Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(4)

Issue 1285793004: isTrusted is incorrect for events generated by Element.click() (Closed)

Created:
5 years, 7 months ago by dtapuska
Modified:
5 years, 6 months ago
Reviewers:
tkent
CC:
blink-reviews, blink-reviews-html_chromium.org, vivekg, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, vivekg_samsung, Inactive, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

isTrusted is incorrect for events generated by Element.click() A click generates a SimulatedMouseEvent which always was a trusted event. This didn't match what FireFox was providing (but did match IE). The decision has been made to match what FF is doing. BUG=334015 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200401

Patch Set 1 #

Total comments: 2

Patch Set 2 : Change bool on SimulatedMouseEvent to the enum class introduced everywhere else #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -22 lines) Patch
M LayoutTests/fast/events/event-trusted.html View 2 chunks +7 lines, -1 line 0 comments Download
M LayoutTests/fast/events/event-trusted-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/dom/Node.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/Node.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/dom/SimulatedClickOptions.h View 1 chunk +5 lines, -0 lines 0 comments Download
M Source/core/events/EventDispatcher.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/events/EventDispatcher.cpp View 1 2 chunks +5 lines, -5 lines 0 comments Download
M Source/core/events/MouseEvent.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/events/MouseEvent.cpp View 1 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/html/HTMLElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLElement.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M Source/core/html/HTMLElement.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/CustomContextMenuProvider.cpp View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
dtapuska
5 years, 7 months ago (2015-08-11 14:16:41 UTC) #2
tkent
lgtm https://codereview.chromium.org/1285793004/diff/1/Source/core/events/MouseEvent.h File Source/core/events/MouseEvent.h (right): https://codereview.chromium.org/1285793004/diff/1/Source/core/events/MouseEvent.h#newcode121 Source/core/events/MouseEvent.h:121: static PassRefPtrWillBeRawPtr<SimulatedMouseEvent> create(const AtomicString& eventType, PassRefPtrWillBeRawPtr<AbstractView>, PassRefPtrWillBeRawPtr<Event> underlyingEvent, ...
5 years, 6 months ago (2015-08-11 23:23:11 UTC) #3
dtapuska
https://codereview.chromium.org/1285793004/diff/1/Source/core/events/MouseEvent.h File Source/core/events/MouseEvent.h (right): https://codereview.chromium.org/1285793004/diff/1/Source/core/events/MouseEvent.h#newcode121 Source/core/events/MouseEvent.h:121: static PassRefPtrWillBeRawPtr<SimulatedMouseEvent> create(const AtomicString& eventType, PassRefPtrWillBeRawPtr<AbstractView>, PassRefPtrWillBeRawPtr<Event> underlyingEvent, bool ...
5 years, 6 months ago (2015-08-12 14:41:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1285793004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1285793004/20001
5 years, 6 months ago (2015-08-12 14:41:28 UTC) #7
commit-bot: I haz the power
5 years, 6 months ago (2015-08-12 16:23:13 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200401

Powered by Google App Engine
This is Rietveld 408576698