Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Side by Side Diff: Source/core/html/HTMLElement.cpp

Issue 1285793004: isTrusted is incorrect for events generated by Element.click() (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Change bool on SimulatedMouseEvent to the enum class introduced everywhere else Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/html/HTMLElement.h ('k') | Source/core/html/HTMLElement.idl » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * Copyright (C) 2004-2008, 2013, 2014 Apple Inc. All rights reserved. 4 * Copyright (C) 2004-2008, 2013, 2014 Apple Inc. All rights reserved.
5 * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/) 5 * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/)
6 * Copyright (C) 2011 Motorola Mobility. All rights reserved. 6 * Copyright (C) 2011 Motorola Mobility. All rights reserved.
7 * 7 *
8 * This library is free software; you can redistribute it and/or 8 * This library is free software; you can redistribute it and/or
9 * modify it under the terms of the GNU Library General Public 9 * modify it under the terms of the GNU Library General Public
10 * License as published by the Free Software Foundation; either 10 * License as published by the Free Software Foundation; either
(...skipping 566 matching lines...) Expand 10 before | Expand all | Expand 10 after
577 bool HTMLElement::spellcheck() const 577 bool HTMLElement::spellcheck() const
578 { 578 {
579 return isSpellCheckingEnabled(); 579 return isSpellCheckingEnabled();
580 } 580 }
581 581
582 void HTMLElement::setSpellcheck(bool enable) 582 void HTMLElement::setSpellcheck(bool enable)
583 { 583 {
584 setAttribute(spellcheckAttr, enable ? "true" : "false"); 584 setAttribute(spellcheckAttr, enable ? "true" : "false");
585 } 585 }
586 586
587 587 void HTMLElement::clickForBindings()
588 void HTMLElement::click()
589 { 588 {
590 dispatchSimulatedClick(0, SendNoEvents); 589 dispatchSimulatedClick(0, SendNoEvents, SimulatedClickCreationScope::FromScr ipt);
591 } 590 }
592 591
593 void HTMLElement::accessKeyAction(bool sendMouseEvents) 592 void HTMLElement::accessKeyAction(bool sendMouseEvents)
594 { 593 {
595 dispatchSimulatedClick(0, sendMouseEvents ? SendMouseUpDownEvents : SendNoEv ents); 594 dispatchSimulatedClick(0, sendMouseEvents ? SendMouseUpDownEvents : SendNoEv ents);
596 } 595 }
597 596
598 String HTMLElement::title() const 597 String HTMLElement::title() const
599 { 598 {
600 return fastGetAttribute(titleAttr); 599 return fastGetAttribute(titleAttr);
(...skipping 418 matching lines...) Expand 10 before | Expand all | Expand 10 after
1019 #ifndef NDEBUG 1018 #ifndef NDEBUG
1020 1019
1021 // For use in the debugger 1020 // For use in the debugger
1022 void dumpInnerHTML(blink::HTMLElement*); 1021 void dumpInnerHTML(blink::HTMLElement*);
1023 1022
1024 void dumpInnerHTML(blink::HTMLElement* element) 1023 void dumpInnerHTML(blink::HTMLElement* element)
1025 { 1024 {
1026 printf("%s\n", element->innerHTML().ascii().data()); 1025 printf("%s\n", element->innerHTML().ascii().data());
1027 } 1026 }
1028 #endif 1027 #endif
OLDNEW
« no previous file with comments | « Source/core/html/HTMLElement.h ('k') | Source/core/html/HTMLElement.idl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698