Source/core/dom/Node.h - Issue 1285793004: isTrusted is incorrect for events generated by Element.click()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/Node.h

Issue 1285793004: isTrusted is incorrect for events generated by Element.click() (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Change bool on SimulatedMouseEvent to the enum class introduced everywhere else Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/dom/Node.h

diff --git a/Source/core/dom/Node.h b/Source/core/dom/Node.h

index 987850210a64146ebf12895c5dba9392f61f1cc1..f793f991be7db7a016325a08b091b3504d9a0bd6 100644

--- a/Source/core/dom/Node.h

+++ b/Source/core/dom/Node.h

@@ -636,7 +636,7 @@ public:

bool dispatchMouseEvent(const PlatformMouseEvent&, const AtomicString& eventType, int clickCount = 0, Node* relatedTarget = nullptr);

bool dispatchGestureEvent(const PlatformGestureEvent&);

- void dispatchSimulatedClick(Event* underlyingEvent, SimulatedClickMouseEventOptions = SendNoEvents);

+ void dispatchSimulatedClick(Event* underlyingEvent, SimulatedClickMouseEventOptions = SendNoEvents, SimulatedClickCreationScope = SimulatedClickCreationScope::FromUserAgent);

void dispatchInputEvent();

« no previous file with comments | « LayoutTests/fast/events/event-trusted-expected.txt ('k') | Source/core/dom/Node.cpp » ('j') | no next file with comments »