Source/core/html/HTMLElement.cpp - Issue 1285793004: isTrusted is incorrect for events generated by Element.click()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLElement.cpp

Issue 1285793004: isTrusted is incorrect for events generated by Element.click() (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Change bool on SimulatedMouseEvent to the enum class introduced everywhere else Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/html/HTMLElement.cpp

diff --git a/Source/core/html/HTMLElement.cpp b/Source/core/html/HTMLElement.cpp

index 6de4687fcb8c1e6364e97e6a1708d1a1607f7ddb..0589a8eb65df11f0146fb180751922ed03348feb 100644

--- a/Source/core/html/HTMLElement.cpp

+++ b/Source/core/html/HTMLElement.cpp

@@ -584,10 +584,9 @@ void HTMLElement::setSpellcheck(bool enable)

setAttribute(spellcheckAttr, enable ? "true" : "false");

}

-void HTMLElement::click()

+void HTMLElement::clickForBindings()

{

- dispatchSimulatedClick(0, SendNoEvents);

+ dispatchSimulatedClick(0, SendNoEvents, SimulatedClickCreationScope::FromScript);

}

void HTMLElement::accessKeyAction(bool sendMouseEvents)

« no previous file with comments | « Source/core/html/HTMLElement.h ('k') | Source/core/html/HTMLElement.idl » ('j') | no next file with comments »