Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(753)

Unified Diff: Source/core/page/CustomContextMenuProvider.cpp

Issue 1285793004: isTrusted is incorrect for events generated by Element.click() (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Change bool on SimulatedMouseEvent to the enum class introduced everywhere else Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/html/HTMLElement.idl ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/page/CustomContextMenuProvider.cpp
diff --git a/Source/core/page/CustomContextMenuProvider.cpp b/Source/core/page/CustomContextMenuProvider.cpp
index 281fea6bb3ee3e68a3c43b2275e16d758845e967..a05fbda2313866003a8dcb9670877e4f5dfc1503 100644
--- a/Source/core/page/CustomContextMenuProvider.cpp
+++ b/Source/core/page/CustomContextMenuProvider.cpp
@@ -45,7 +45,7 @@ void CustomContextMenuProvider::populateContextMenu(ContextMenu* menu)
void CustomContextMenuProvider::contextMenuItemSelected(const ContextMenuItem* item)
{
if (HTMLElement* element = menuItemAt(item->action())) {
- RefPtrWillBeRawPtr<SimulatedMouseEvent> click = SimulatedMouseEvent::create(EventTypeNames::click, m_menu->document().domWindow(), Event::create());
+ RefPtrWillBeRawPtr<SimulatedMouseEvent> click = SimulatedMouseEvent::create(EventTypeNames::click, m_menu->document().domWindow(), Event::create(), SimulatedClickCreationScope::FromUserAgent);
click->setRelatedTarget(m_subjectElement.get());
element->dispatchEvent(click.release());
}
« no previous file with comments | « Source/core/html/HTMLElement.idl ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698