Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1444)

Issue 1285233004: Get rid of a redundant argument DOWNSTREAM from VisiblePosition constructor call sites (Closed)

Created:
5 years, 4 months ago by yosin_UTC9
Modified:
5 years, 4 months ago
Reviewers:
tkent
CC:
blink-reviews, aboxhall, blink-reviews-html_chromium.org, dglazkov+blink, nektarios, dmazzoni, groby+blinkspell_chromium.org, je_julie, yoichio
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Get rid of a redundant argument DOWNSTREAM from VisiblePosition constructor call sites This patch gets rid of a redundant argument DOWNSTREAM from |VisiblePosition| constructor call sites to simplify source code for improving code health, since default value of affinity is |DOWNSTREAM| in each constructor declarations. This patch is a preparation of introducing |TextAffinity| enum class as replacement of |EAffinity|, http://crbug.com/522038. BUG=522038 TEST=n/a; no behavior changes Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200796

Patch Set 1 : 2015-08-19T10:38:53 #

Patch Set 2 : 2015-08-19T12:36:19 Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -37 lines) Patch
M Source/core/editing/DOMSelection.cpp View 4 chunks +5 lines, -5 lines 0 comments Download
M Source/core/editing/EditingUtilities.cpp View 4 chunks +6 lines, -6 lines 0 comments Download
M Source/core/editing/Editor.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/SelectionController.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/VisiblePosition.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/editing/VisibleUnits.cpp View 1 9 chunks +13 lines, -13 lines 0 comments Download
M Source/core/editing/commands/InsertTextCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/commands/ReplaceSelectionCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/iterators/TextIterator.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/editing/spellcheck/SpellChecker.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLTextFormControlElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/accessibility/AXLayoutObject.cpp View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (7 generated)
yosin_UTC9
PTAL
5 years, 4 months ago (2015-08-19 02:00:58 UTC) #2
tkent
lgtm
5 years, 4 months ago (2015-08-19 02:09:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1285233004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1285233004/1
5 years, 4 months ago (2015-08-19 02:09:28 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_dbg_recipe/builds/108736)
5 years, 4 months ago (2015-08-19 02:52:54 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1285233004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1285233004/1
5 years, 4 months ago (2015-08-19 03:18:54 UTC) #9
commit-bot: I haz the power
Failed to apply patch for Source/core/editing/commands/CompositeEditCommand.cpp: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
5 years, 4 months ago (2015-08-19 03:30:52 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1285233004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1285233004/20001
5 years, 4 months ago (2015-08-19 03:38:29 UTC) #14
commit-bot: I haz the power
5 years, 4 months ago (2015-08-19 04:38:51 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200796

Powered by Google App Engine
This is Rietveld 408576698