Source/core/editing/Editor.cpp - Issue 1285233004: Get rid of a redundant argument DOWNSTREAM from VisiblePosition constructor call sites

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/editing/Editor.cpp

Issue 1285233004: Get rid of a redundant argument DOWNSTREAM from VisiblePosition constructor call sites (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: 2015-08-19T12:36:19 Rebase Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/editing/Editor.cpp

diff --git a/Source/core/editing/Editor.cpp b/Source/core/editing/Editor.cpp

index 1fe72cb496c9837afbddd296b6ddc09b416ca329..aee1ba1286300c0ee1a697c4f3912b16379e9105 100644

--- a/Source/core/editing/Editor.cpp

+++ b/Source/core/editing/Editor.cpp

@@ -255,7 +255,7 @@ bool Editor::canDeleteRange(const EphemeralRange& range) const

return false;

if (range.isCollapsed()) {

- VisiblePosition start(range.startPosition(), DOWNSTREAM);

+ VisiblePosition start(range.startPosition());

VisiblePosition previous = start.previous();

// FIXME: We sometimes allow deletions at the start of editable roots, like when the caret is in an empty list item.

if (previous.isNull() || previous.deepEquivalent().anchorNode()->rootEditableElement() != startContainer->rootEditableElement())

« no previous file with comments | « Source/core/editing/EditingUtilities.cpp ('k') | Source/core/editing/SelectionController.cpp » ('j') | no next file with comments »