Source/core/editing/commands/ReplaceSelectionCommand.cpp - Issue 1285233004: Get rid of a redundant argument DOWNSTREAM from VisiblePosition constructor call sites

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/editing/commands/ReplaceSelectionCommand.cpp

Issue 1285233004: Get rid of a redundant argument DOWNSTREAM from VisiblePosition constructor call sites (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: 2015-08-19T12:36:19 Rebase Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/editing/commands/ReplaceSelectionCommand.cpp

diff --git a/Source/core/editing/commands/ReplaceSelectionCommand.cpp b/Source/core/editing/commands/ReplaceSelectionCommand.cpp

index 9590c4d421916d3ef4a88094f8873fed35c18520..d12f1c3014d62942b54f3921d0283076141e98a3 100644

--- a/Source/core/editing/commands/ReplaceSelectionCommand.cpp

+++ b/Source/core/editing/commands/ReplaceSelectionCommand.cpp

@@ -1032,7 +1032,7 @@ void ReplaceSelectionCommand::doApply()

HTMLBRElement* endBR = isHTMLBRElement(*insertionPos.downstream().anchorNode()) ? toHTMLBRElement(insertionPos.downstream().anchorNode()) : 0;

VisiblePosition originalVisPosBeforeEndBR;

if (endBR)

- originalVisPosBeforeEndBR = VisiblePosition(positionBeforeNode(endBR), DOWNSTREAM).previous();

+ originalVisPosBeforeEndBR = VisiblePosition(positionBeforeNode(endBR)).previous();

RefPtrWillBeRawPtr<Element> enclosingBlockOfInsertionPos = enclosingBlock(insertionPos.anchorNode());

« no previous file with comments | « Source/core/editing/commands/InsertTextCommand.cpp ('k') | Source/core/editing/iterators/TextIterator.cpp » ('j') | no next file with comments »