Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(898)

Unified Diff: Source/core/editing/EditingUtilities.cpp

Issue 1285233004: Get rid of a redundant argument DOWNSTREAM from VisiblePosition constructor call sites (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: 2015-08-19T12:36:19 Rebase Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/editing/DOMSelection.cpp ('k') | Source/core/editing/Editor.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/editing/EditingUtilities.cpp
diff --git a/Source/core/editing/EditingUtilities.cpp b/Source/core/editing/EditingUtilities.cpp
index b1c37775692c1b4bbd01692bc629f2dd0da60ba3..313dfc53ac8416ec2b6aca471fd60549d21fec6d 100644
--- a/Source/core/editing/EditingUtilities.cpp
+++ b/Source/core/editing/EditingUtilities.cpp
@@ -637,8 +637,8 @@ static HTMLElement* firstInSpecialElement(const Position& pos)
for (Node* n = pos.anchorNode(); n && n->rootEditableElement() == rootEditableElement; n = n->parentNode()) {
if (isSpecialHTMLElement(*n)) {
HTMLElement* specialElement = toHTMLElement(n);
- VisiblePosition vPos = VisiblePosition(pos, DOWNSTREAM);
- VisiblePosition firstInElement = VisiblePosition(firstPositionInOrBeforeNode(specialElement), DOWNSTREAM);
+ VisiblePosition vPos = VisiblePosition(pos);
+ VisiblePosition firstInElement = VisiblePosition(firstPositionInOrBeforeNode(specialElement));
if (isRenderedTableElement(specialElement) && vPos.deepEquivalent() == firstInElement.next().deepEquivalent())
return specialElement;
if (vPos.deepEquivalent() == firstInElement.deepEquivalent())
@@ -654,8 +654,8 @@ static HTMLElement* lastInSpecialElement(const Position& pos)
for (Node* n = pos.anchorNode(); n && n->rootEditableElement() == rootEditableElement; n = n->parentNode()) {
if (isSpecialHTMLElement(*n)) {
HTMLElement* specialElement = toHTMLElement(n);
- VisiblePosition vPos = VisiblePosition(pos, DOWNSTREAM);
- VisiblePosition lastInElement = VisiblePosition(lastPositionInOrAfterNode(specialElement), DOWNSTREAM);
+ VisiblePosition vPos = VisiblePosition(pos);
+ VisiblePosition lastInElement = VisiblePosition(lastPositionInOrAfterNode(specialElement));
if (isRenderedTableElement(specialElement) && vPos.deepEquivalent() == lastInElement.previous().deepEquivalent())
return specialElement;
if (vPos.deepEquivalent() == lastInElement.deepEquivalent())
@@ -760,7 +760,7 @@ Node* nextAtomicLeafNode(const Node& start)
VisiblePosition visiblePositionBeforeNode(Node& node)
{
if (node.hasChildren())
- return VisiblePosition(firstPositionInOrBeforeNode(&node), DOWNSTREAM);
+ return VisiblePosition(firstPositionInOrBeforeNode(&node));
ASSERT(node.parentNode());
ASSERT(!node.parentNode()->isShadowRoot());
return VisiblePosition(positionInParentBeforeNode(node));
@@ -770,7 +770,7 @@ VisiblePosition visiblePositionBeforeNode(Node& node)
VisiblePosition visiblePositionAfterNode(Node& node)
{
if (node.hasChildren())
- return VisiblePosition(lastPositionInOrAfterNode(&node), DOWNSTREAM);
+ return VisiblePosition(lastPositionInOrAfterNode(&node));
ASSERT(node.parentNode());
ASSERT(!node.parentNode()->isShadowRoot());
return VisiblePosition(positionInParentAfterNode(node));
« no previous file with comments | « Source/core/editing/DOMSelection.cpp ('k') | Source/core/editing/Editor.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698