Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(620)

Unified Diff: Source/core/editing/spellcheck/SpellChecker.cpp

Issue 1285233004: Get rid of a redundant argument DOWNSTREAM from VisiblePosition constructor call sites (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: 2015-08-19T12:36:19 Rebase Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/editing/iterators/TextIterator.cpp ('k') | Source/core/html/HTMLTextFormControlElement.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/editing/spellcheck/SpellChecker.cpp
diff --git a/Source/core/editing/spellcheck/SpellChecker.cpp b/Source/core/editing/spellcheck/SpellChecker.cpp
index c38d891e812c504f0b0a08f37960247c9fd44279..2d7e4fd1c407fb58c2e42f9652cdfad43b8cb5ec 100644
--- a/Source/core/editing/spellcheck/SpellChecker.cpp
+++ b/Source/core/editing/spellcheck/SpellChecker.cpp
@@ -211,7 +211,7 @@ void SpellChecker::advanceToNextMisspelling(bool startBeforeSelection)
// If spellingSearchRange starts in the middle of a word, advance to the next word so we start checking
// at a word boundary. Going back by one char and then forward by a word does the trick.
if (startedWithSelection) {
- VisiblePosition oneBeforeStart = VisiblePosition(spellingSearchStart, DOWNSTREAM).previous();
+ VisiblePosition oneBeforeStart = VisiblePosition(spellingSearchStart).previous();
if (oneBeforeStart.isNotNull())
spellingSearchStart = endOfWord(oneBeforeStart).toParentAnchoredPosition();
// else we were already at the start of the editable node
@@ -316,7 +316,7 @@ void SpellChecker::advanceToNextMisspelling(bool startBeforeSelection)
// a marker so we draw the red squiggle later.
const EphemeralRange misspellingRange = calculateCharacterSubrange(EphemeralRange(spellingSearchStart, spellingSearchEnd), misspellingOffset, misspelledWord.length());
- frame().selection().setSelection(VisibleSelection(misspellingRange, DOWNSTREAM));
+ frame().selection().setSelection(VisibleSelection(misspellingRange));
frame().selection().revealSelection();
spellCheckerClient().updateSpellingUIWithMisspelledWord(misspelledWord);
« no previous file with comments | « Source/core/editing/iterators/TextIterator.cpp ('k') | Source/core/html/HTMLTextFormControlElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698