Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(373)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1285183006: DevTools: WI.Throttler goes promisified. (Closed)

Created:
5 years, 4 months ago by lushnikov
Modified:
5 years, 4 months ago
Reviewers:
pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, blink-reviews-style_chromium.org, aboxhall, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, nektarios, dmazzoni, apavlov+blink_chromium.org, devtools-reviews_chromium.org, je_julie, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@cc
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

DevTools: WI.Throttler goes promisified. The patch moves WI.Throttler interface to the promises. BUG=508960 R=pfeldman Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200577

Patch Set 1 #

Patch Set 2 : fix tests; address @dgozman #

Patch Set 3 : rebaseline #

Patch Set 4 : remove dependent patchset #

Unified diffs Side-by-side diffs Delta from patch set Stats (+230 lines, -213 lines) Patch
M LayoutTests/http/tests/inspector/elements-test.js View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/elements/styles-1/color-aware-property-value-edit.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/elements/styles-2/lazy-computed-style.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/throttler.html View 6 chunks +107 lines, -47 lines 0 comments Download
M Source/devtools/front_end/accessibility/AccessibilitySidebarView.js View 2 chunks +3 lines, -5 lines 0 comments Download
M Source/devtools/front_end/bindings/StylesSourceMapping.js View 1 chunk +3 lines, -7 lines 0 comments Download
M Source/devtools/front_end/bindings/WorkspaceController.js View 1 chunk +2 lines, -3 lines 0 comments Download
M Source/devtools/front_end/common/Throttler.js View 1 2 chunks +7 lines, -17 lines 0 comments Download
M Source/devtools/front_end/console/ConsoleView.js View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/devtools/front_end/elements/ComputedStyleWidget.js View 1 chunk +4 lines, -5 lines 0 comments Download
M Source/devtools/front_end/elements/ElementsSidebarPane.js View 3 chunks +7 lines, -10 lines 0 comments Download
M Source/devtools/front_end/elements/EventListenersWidget.js View 3 chunks +4 lines, -5 lines 0 comments Download
M Source/devtools/front_end/elements/MetricsSidebarPane.js View 2 chunks +6 lines, -11 lines 0 comments Download
M Source/devtools/front_end/elements/PlatformFontsWidget.js View 1 chunk +6 lines, -9 lines 0 comments Download
M Source/devtools/front_end/elements/PropertiesWidget.js View 2 chunks +4 lines, -7 lines 0 comments Download
M Source/devtools/front_end/elements/StylesSidebarPane.js View 6 chunks +10 lines, -17 lines 0 comments Download
M Source/devtools/front_end/emulation/MediaQueryInspector.js View 1 chunk +4 lines, -11 lines 0 comments Download
M Source/devtools/front_end/emulation/OverridesSupport.js View 1 chunk +7 lines, -10 lines 0 comments Download
M Source/devtools/front_end/emulation/ResponsiveDesignView.js View 4 chunks +9 lines, -9 lines 0 comments Download
M Source/devtools/front_end/network/NetworkTimeCalculator.js View 1 chunk +11 lines, -1 line 0 comments Download
M Source/devtools/front_end/platform/utilities.js View 1 chunk +17 lines, -0 lines 0 comments Download
M Source/devtools/front_end/profiler/HeapSnapshotView.js View 4 chunks +3 lines, -23 lines 0 comments Download
M Source/devtools/front_end/ui/ThrottledWidget.js View 2 chunks +7 lines, -7 lines 0 comments Download
M Source/devtools/front_end/ui_lazy/TimelineOverviewPane.js View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
lushnikov
ptal
5 years, 4 months ago (2015-08-14 01:09:52 UTC) #1
pfeldman
lgtm beautiful
5 years, 4 months ago (2015-08-14 01:34:53 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1285183006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1285183006/1
5 years, 4 months ago (2015-08-14 05:50:41 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/66206)
5 years, 4 months ago (2015-08-14 06:40:47 UTC) #6
commit-bot: I haz the power
This CL has an open dependency (Issue 1291483002 Patch 80001). Please resolve the dependency and ...
5 years, 4 months ago (2015-08-14 21:01:24 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1285183006/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1285183006/60001
5 years, 4 months ago (2015-08-14 21:57:44 UTC) #13
commit-bot: I haz the power
5 years, 4 months ago (2015-08-14 23:54:14 UTC) #14
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200577

Powered by Google App Engine
This is Rietveld 408576698