Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1209)

Unified Diff: Source/devtools/front_end/elements/EventListenersWidget.js

Issue 1285183006: DevTools: WI.Throttler goes promisified. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@cc
Patch Set: remove dependent patchset Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/elements/EventListenersWidget.js
diff --git a/Source/devtools/front_end/elements/EventListenersWidget.js b/Source/devtools/front_end/elements/EventListenersWidget.js
index d704e0e2f9ab7323ae4f4cfda5d8dc0c70f20eee..f8b0a1d62470b7f348dbce11cf967949dce14daa 100644
--- a/Source/devtools/front_end/elements/EventListenersWidget.js
+++ b/Source/devtools/front_end/elements/EventListenersWidget.js
@@ -61,10 +61,10 @@ WebInspector.EventListenersWidget._objectGroupName = "event-listeners-panel";
WebInspector.EventListenersWidget.prototype = {
/**
* @override
- * @param {!WebInspector.Throttler.FinishCallback} finishCallback
* @protected
+ * @return {!Promise.<?>}
*/
- doUpdate: function(finishCallback)
+ doUpdate: function()
{
if (this._lastRequestedNode) {
this._lastRequestedNode.target().runtimeAgent().releaseObjectGroup(WebInspector.EventListenersWidget._objectGroupName);
@@ -74,8 +74,7 @@ WebInspector.EventListenersWidget.prototype = {
if (!node) {
this._eventListenersView.reset();
this._eventListenersView.addEmptyHolderIfNeeded();
- finishCallback();
- return;
+ return Promise.resolve();
}
this._lastRequestedNode = node;
var selectedNodeOnly = !this._showForAncestorsSetting.get();
@@ -90,7 +89,7 @@ WebInspector.EventListenersWidget.prototype = {
}
promises.push(this._windowObjectInNodeContext(node));
}
- Promise.all(promises).then(this._eventListenersView.addObjects.bind(this._eventListenersView)).then(finishCallback.bind(this, undefined));
+ return Promise.all(promises).then(this._eventListenersView.addObjects.bind(this._eventListenersView));
},
/**
« no previous file with comments | « Source/devtools/front_end/elements/ElementsSidebarPane.js ('k') | Source/devtools/front_end/elements/MetricsSidebarPane.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698