Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1643)

Unified Diff: Source/devtools/front_end/elements/MetricsSidebarPane.js

Issue 1285183006: DevTools: WI.Throttler goes promisified. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@cc
Patch Set: remove dependent patchset Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/elements/MetricsSidebarPane.js
diff --git a/Source/devtools/front_end/elements/MetricsSidebarPane.js b/Source/devtools/front_end/elements/MetricsSidebarPane.js
index 6996392c216b5f20f54338604060640612922931..ed575b7298cdcd471c899da4435a59f21569b227 100644
--- a/Source/devtools/front_end/elements/MetricsSidebarPane.js
+++ b/Source/devtools/front_end/elements/MetricsSidebarPane.js
@@ -38,25 +38,22 @@ WebInspector.MetricsSidebarPane = function()
WebInspector.MetricsSidebarPane.prototype = {
/**
* @override
- * @param {!WebInspector.Throttler.FinishCallback} finishedCallback
* @protected
+ * @return {!Promise.<?>}
*/
- doUpdate: function(finishedCallback)
+ doUpdate: function()
{
// "style" attribute might have changed. Update metrics unless they are being edited
// (if a CSS property is added, a StyleSheetChanged event is dispatched).
- if (this._isEditingMetrics) {
- finishedCallback();
- return;
- }
+ if (this._isEditingMetrics)
+ return Promise.resolve();
// FIXME: avoid updates of a collapsed pane.
var node = this.node();
var cssModel = this.cssModel();
if (!node || node.nodeType() !== Node.ELEMENT_NODE || !cssModel) {
this.element.removeChildren();
- finishedCallback();
- return;
+ return Promise.resolve();
}
/**
@@ -83,9 +80,7 @@ WebInspector.MetricsSidebarPane.prototype = {
cssModel.computedStylePromise(node.id).then(callback.bind(this)),
cssModel.inlineStylesPromise(node.id).then(inlineStyleCallback.bind(this))
];
- Promise.all(promises)
- .then(finishedCallback.bind(null, undefined))
- .catch(/** @type {function()} */(finishedCallback));
+ return Promise.all(promises);
},
/**
« no previous file with comments | « Source/devtools/front_end/elements/EventListenersWidget.js ('k') | Source/devtools/front_end/elements/PlatformFontsWidget.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698