Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1912)

Unified Diff: Source/devtools/front_end/elements/PropertiesWidget.js

Issue 1285183006: DevTools: WI.Throttler goes promisified. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@cc
Patch Set: remove dependent patchset Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/elements/PropertiesWidget.js
diff --git a/Source/devtools/front_end/elements/PropertiesWidget.js b/Source/devtools/front_end/elements/PropertiesWidget.js
index c4c6279ce4464e2edce0ae91739f30a6fea58c3c..6b4578c0a69ce46e0335de054bdf62c547f77ec1 100644
--- a/Source/devtools/front_end/elements/PropertiesWidget.js
+++ b/Source/devtools/front_end/elements/PropertiesWidget.js
@@ -64,10 +64,10 @@ WebInspector.PropertiesWidget.prototype = {
/**
* @override
- * @param {!WebInspector.Throttler.FinishCallback} finishCallback
* @protected
+ * @return {!Promise.<?>}
*/
- doUpdate: function(finishCallback)
+ doUpdate: function()
{
if (this._lastRequestedNode) {
this._lastRequestedNode.target().runtimeAgent().releaseObjectGroup(WebInspector.PropertiesWidget._objectGroupName);
@@ -77,15 +77,12 @@ WebInspector.PropertiesWidget.prototype = {
if (!this._node) {
this.element.removeChildren();
this.sections = [];
- finishCallback();
- return;
+ return Promise.resolve();
}
this._lastRequestedNode = this._node;
- this._node.resolveToObjectPromise(WebInspector.PropertiesWidget._objectGroupName)
+ return this._node.resolveToObjectPromise(WebInspector.PropertiesWidget._objectGroupName)
.then(nodeResolved.bind(this))
- .then(finishCallback)
- .catch(/** @type {function()} */(finishCallback));
/**
* @param {?WebInspector.RemoteObject} object
« no previous file with comments | « Source/devtools/front_end/elements/PlatformFontsWidget.js ('k') | Source/devtools/front_end/elements/StylesSidebarPane.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698