Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1155)

Unified Diff: Source/devtools/front_end/accessibility/AccessibilitySidebarView.js

Issue 1285183006: DevTools: WI.Throttler goes promisified. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@cc
Patch Set: remove dependent patchset Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/inspector/throttler.html ('k') | Source/devtools/front_end/bindings/StylesSourceMapping.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/devtools/front_end/accessibility/AccessibilitySidebarView.js
diff --git a/Source/devtools/front_end/accessibility/AccessibilitySidebarView.js b/Source/devtools/front_end/accessibility/AccessibilitySidebarView.js
index 8778e5e495420c8ec5e3d7e3c9f3f740e9ec07d5..d6333c3361922fb844409283ae8ecb5cbbc68d71 100644
--- a/Source/devtools/front_end/accessibility/AccessibilitySidebarView.js
+++ b/Source/devtools/front_end/accessibility/AccessibilitySidebarView.js
@@ -28,10 +28,10 @@ WebInspector.AccessibilitySidebarView.prototype = {
/**
* @override
- * @param {!WebInspector.Throttler.FinishCallback} finishCallback
* @protected
+ * @return {!Promise.<?>}
*/
- doUpdate: function(finishCallback)
+ doUpdate: function()
{
/**
* @param {?AccessibilityAgent.AXNode} accessibilityNode
@@ -45,10 +45,8 @@ WebInspector.AccessibilitySidebarView.prototype = {
this._axNodeSubPane.setAXNode(accessibilityNode);
}
var node = this.node();
- WebInspector.AccessibilityModel.fromTarget(node.target()).getAXNode(node.id)
+ return WebInspector.AccessibilityModel.fromTarget(node.target()).getAXNode(node.id)
.then(accessibilityNodeCallback.bind(this))
- .then(finishCallback)
- .catch(/** @type {function()} */(finishCallback));
},
/**
« no previous file with comments | « LayoutTests/inspector/throttler.html ('k') | Source/devtools/front_end/bindings/StylesSourceMapping.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698