Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 1284083002: Print stack traces in child processes when browser tests failed. (Closed)

Created:
5 years, 4 months ago by jam
Modified:
4 years, 8 months ago
Reviewers:
CC:
chromium-reviews, mkwst+moarreviews-renderer_chromium.org, darin-cc_chromium.org, jam, mlamouri+watch-content_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Print stack traces in child processes when browser tests failed. The functionality to do this opens up security holes. Currently this was working only for debug Linux builds. However our trybots are release builds, and we need to be able to see stack traces from child processes on all platforms (i.e. to be able to debug the large flakiness that occurred since last week). This is disabled for official builds. The Windows fix is from scottmg's fix in r261253. BUG=517488, 358267 patch from issue 1291553003 at patchset 1 (http://crrev.com/1291553003#ps1)

Patch Set 1 #

Patch Set 2 : renable tests #

Patch Set 3 : try exposing PDBs #

Patch Set 4 : dont use 32bit dbghelp #

Patch Set 5 : fix rel64 #

Patch Set 6 : more fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+126 lines, -130 lines) Patch
M base/base.isolate View 1 2 3 1 chunk +0 lines, -8 lines 0 comments Download
M base/debug/stack_trace.h View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M base/debug/stack_trace_posix.cc View 6 chunks +11 lines, -14 lines 0 comments Download
M base/debug/stack_trace_win.cc View 1 2 3 4 5 6 chunks +54 lines, -61 lines 0 comments Download
M base/process/launch_win.cc View 1 chunk +16 lines, -2 lines 0 comments Download
M chrome/browser/banners/app_banner_data_fetcher_browsertest.cc View 1 12 chunks +12 lines, -12 lines 0 comments Download
M chrome/browser/extensions/api/activity_log_private/activity_log_private_apitest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/error_console/error_console_browsertest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/webstore_inline_installer_browsertest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media/encrypted_media_browsertest.cc View 1 4 chunks +1 line, -4 lines 0 comments Download
M chrome/browser/ui/search/instant_extended_interactive_uitest.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/test/data/webui/history_browsertest.js View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/webui/net_internals/bandwidth_view.js View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/webui/net_internals/dns_view.js View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/webui/net_internals/log_util.js View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/webui/net_internals/prerender_view.js View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/test/data/webui/net_internals/sdch_view.js View 1 3 chunks +3 lines, -3 lines 0 comments Download
M content/app/content_main_runner.cc View 2 chunks +10 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M content/common/sandbox_win.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/render_thread_impl.cc View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M content/renderer/renderer_main.cc View 2 chunks +1 line, -11 lines 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698