Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/banners/app_banner_data_fetcher_browsertest.cc

Issue 1284083002: Print stack traces in child processes when browser tests failed. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: more fixes Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/process/launch_win.cc ('k') | chrome/browser/extensions/api/activity_log_private/activity_log_private_apitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/banners/app_banner_data_fetcher_browsertest.cc
diff --git a/chrome/browser/banners/app_banner_data_fetcher_browsertest.cc b/chrome/browser/banners/app_banner_data_fetcher_browsertest.cc
index 8f789b9e0a8a5582c8bead82690579a5fcc06329..1c3ff0ab98d9e310c7205636292bcd5f15071d26 100644
--- a/chrome/browser/banners/app_banner_data_fetcher_browsertest.cc
+++ b/chrome/browser/banners/app_banner_data_fetcher_browsertest.cc
@@ -151,7 +151,7 @@ IN_PROC_BROWSER_TEST_F(AppBannerDataFetcherBrowserTest,
// http://crbug.com/517307
#if defined(OS_WIN)
#define MAYBE_WebAppBannerCreatedDirectSingle \
- DISABLED_WebAppBannerCreatedDirectSingle
+ WebAppBannerCreatedDirectSingle
#else
#define MAYBE_WebAppBannerCreatedDirectSingle WebAppBannerCreatedDirectSingle
#endif
@@ -165,7 +165,7 @@ IN_PROC_BROWSER_TEST_F(AppBannerDataFetcherBrowserTest,
// http://crbug.com/517307
#if defined(OS_WIN)
#define MAYBE_WebAppBannerCreatedDirectMultiple \
- DISABLED_WebAppBannerCreatedDirectMultiple
+ WebAppBannerCreatedDirectMultiple
#else
#define MAYBE_WebAppBannerCreatedDirectMultiple \
WebAppBannerCreatedDirectMultiple
@@ -179,7 +179,7 @@ IN_PROC_BROWSER_TEST_F(AppBannerDataFetcherBrowserTest,
// http://crbug.com/517307
#if defined(OS_WIN)
-#define MAYBE_WebAppBannerCreatedIndirect DISABLED_WebAppBannerCreatedIndirect
+#define MAYBE_WebAppBannerCreatedIndirect WebAppBannerCreatedIndirect
#else
#define MAYBE_WebAppBannerCreatedIndirect WebAppBannerCreatedIndirect
#endif
@@ -199,7 +199,7 @@ IN_PROC_BROWSER_TEST_F(AppBannerDataFetcherBrowserTest,
// http://crbug.com/517307
#if defined(OS_WIN)
#define MAYBE_WebAppBannerCreatedIndirectMultiple \
- DISABLED_WebAppBannerCreatedIndirectMultiple
+ WebAppBannerCreatedIndirectMultiple
#else
#define MAYBE_WebAppBannerCreatedIndirectMultiple \
WebAppBannerCreatedIndirectMultiple
@@ -213,7 +213,7 @@ IN_PROC_BROWSER_TEST_F(AppBannerDataFetcherBrowserTest,
// http://crbug.com/517307
#if defined(OS_WIN)
-#define MAYBE_WebAppBannerCreatedVarious DISABLED_WebAppBannerCreatedVarious
+#define MAYBE_WebAppBannerCreatedVarious WebAppBannerCreatedVarious
#else
#define MAYBE_WebAppBannerCreatedVarious WebAppBannerCreatedVarious
#endif
@@ -267,7 +267,7 @@ IN_PROC_BROWSER_TEST_F(AppBannerDataFetcherBrowserTest,
// http://crbug.com/517307
#if defined(OS_WIN)
-#define MAYBE_WebAppBannerNoTypeInManifest DISABLED_WebAppBannerNoTypeInManifest
+#define MAYBE_WebAppBannerNoTypeInManifest WebAppBannerNoTypeInManifest
#else
#define MAYBE_WebAppBannerNoTypeInManifest WebAppBannerNoTypeInManifest
#endif
@@ -279,7 +279,7 @@ IN_PROC_BROWSER_TEST_F(AppBannerDataFetcherBrowserTest,
// http://crbug.com/517307
#if defined(OS_WIN)
-#define MAYBE_WebAppBannerNoTypeInManifestCapsExtension DISABLED_WebAppBannerNoTypeInManifestCapsExtension
+#define MAYBE_WebAppBannerNoTypeInManifestCapsExtension WebAppBannerNoTypeInManifestCapsExtension
#else
#define MAYBE_WebAppBannerNoTypeInManifestCapsExtension WebAppBannerNoTypeInManifestCapsExtension
#endif
@@ -307,7 +307,7 @@ IN_PROC_BROWSER_TEST_F(AppBannerDataFetcherBrowserTest, PlayAppManifest) {
// http://crbug.com/517307
#if defined(OS_WIN)
-#define MAYBE_NoManifest DISABLED_NoManifest
+#define MAYBE_NoManifest NoManifest
#else
#define MAYBE_NoManifest NoManifest
#endif
@@ -318,7 +318,7 @@ IN_PROC_BROWSER_TEST_F(AppBannerDataFetcherBrowserTest, MAYBE_NoManifest) {
// http://crbug.com/517307
#if defined(OS_WIN)
-#define MAYBE_CancelBannerDirect DISABLED_CancelBannerDirect
+#define MAYBE_CancelBannerDirect CancelBannerDirect
#else
#define MAYBE_CancelBannerDirect CancelBannerDirect
#endif
@@ -336,7 +336,7 @@ IN_PROC_BROWSER_TEST_F(AppBannerDataFetcherBrowserTest, CancelBannerIndirect) {
// http://crbug.com/517307
#if defined(OS_WIN)
-#define MAYBE_PromptBanner DISABLED_PromptBanner
+#define MAYBE_PromptBanner PromptBanner
#else
#define MAYBE_PromptBanner PromptBanner
#endif
@@ -347,7 +347,7 @@ IN_PROC_BROWSER_TEST_F(AppBannerDataFetcherBrowserTest, MAYBE_PromptBanner) {
// http://crbug.com/517307
#if defined(OS_WIN)
-#define MAYBE_PromptBannerInHandler DISABLED_PromptBannerInHandler
+#define MAYBE_PromptBannerInHandler PromptBannerInHandler
#else
#define MAYBE_PromptBannerInHandler PromptBannerInHandler
#endif
@@ -359,7 +359,7 @@ IN_PROC_BROWSER_TEST_F(AppBannerDataFetcherBrowserTest,
// http://crbug.com/517307
#if defined(OS_WIN)
-#define MAYBE_WebAppBannerInIFrame DISABLED_WebAppBannerInIFrame
+#define MAYBE_WebAppBannerInIFrame WebAppBannerInIFrame
#else
#define MAYBE_WebAppBannerInIFrame WebAppBannerInIFrame
#endif
« no previous file with comments | « base/process/launch_win.cc ('k') | chrome/browser/extensions/api/activity_log_private/activity_log_private_apitest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698