chrome/browser/extensions/error_console/error_console_browsertest.cc - Issue 1284083002: Print stack traces in child processes when browser tests failed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/error_console/error_console_browsertest.cc

Issue 1284083002: Print stack traces in child processes when browser tests failed. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: more fixes Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/activity_log_private/activity_log_private_apitest.cc ('k') | chrome/browser/extensions/webstore_inline_installer_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/error_console/error_console_browsertest.cc

diff --git a/chrome/browser/extensions/error_console/error_console_browsertest.cc b/chrome/browser/extensions/error_console/error_console_browsertest.cc

index e55f097db05459b2c0cf44c14b4cdbe939960534..ab7d8dbaed9ad3a122101b299b64437aa4ac2ebb 100644

--- a/chrome/browser/extensions/error_console/error_console_browsertest.cc

+++ b/chrome/browser/extensions/error_console/error_console_browsertest.cc

@@ -422,7 +422,7 @@ IN_PROC_BROWSER_TEST_F(ErrorConsoleBrowserTest,

// Catch an error from a BrowserAction; this is more complex than a content

// script error, since browser actions are routed through our own code.

#if defined(OS_WIN) // Flakes on XP. http://crbug.com/517029

-#define MAYBE_BrowserActionRuntimeError DISABLED_BrowserActionRuntimeError

+#define MAYBE_BrowserActionRuntimeError BrowserActionRuntimeError

#else

#define MAYBE_BrowserActionRuntimeError BrowserActionRuntimeError

#endif