Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Issue 1282503003: Remove several grab-bag includes from the v8.h header. (Closed)

Created:
5 years, 4 months ago by Michael Starzinger
Modified:
5 years, 4 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove several grab-bag includes from the v8.h header. This is the first step of turning the v8.h file into a normal header instead of an include-the-world header. The new rule is that no other header files are allowed to include v8.h, which is enforced by DEPS. Also the number of includes inside the v8.h file has been drastically reduced. Basically the last missing piece is the inclusion of the big objects-inl.h file. This in turn makes many headers follow the IWYU principle. R=bmeurer@chromium.org,hpayer@chromium.org,titzer@chromium.org Committed: https://crrev.com/58109a2c5038fbbb208904d4edfc0a7a758928c3 Cr-Commit-Position: refs/heads/master@{#30102}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -87 lines) Patch
M src/DEPS View 1 chunk +6 lines, -0 lines 0 comments Download
M src/accessors.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/api.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/api.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/arm/lithium-gap-resolver-arm.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/arm64/constants-arm64.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/arm64/disasm-arm64.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/arm64/lithium-gap-resolver-arm64.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/arm64/simulator-arm64.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/arm64/utils-arm64.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/assembler.h View 1 chunk +1 line, -3 lines 0 comments Download
M src/ast.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/ast-literal-reindexer.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/basic-block-profiler.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/compiler.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/basic-block-instrumentor.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/d8.h View 1 chunk +1 line, -1 line 0 comments Download
M src/deoptimizer.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/effects.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/expression-classifier.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/extensions/externalize-string-extension.h View 1 chunk +1 line, -1 line 0 comments Download
M src/extensions/externalize-string-extension.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M src/extensions/free-buffer-extension.h View 1 chunk +1 line, -1 line 0 comments Download
M src/extensions/gc-extension.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/extensions/statistics-extension.h View 1 chunk +1 line, -1 line 0 comments Download
M src/extensions/statistics-extension.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/extensions/trigger-failure-extension.h View 1 chunk +1 line, -1 line 0 comments Download
M src/full-codegen/full-codegen.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/gdb-jit.h View 1 chunk +1 line, -1 line 0 comments Download
M src/globals.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/hydrogen.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/hydrogen-instructions.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/i18n.h View 1 chunk +1 line, -1 line 0 comments Download
M src/i18n.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M src/ia32/lithium-gap-resolver-ia32.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/json-parser.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/json-stringifier.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/lithium-allocator.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/lithium-codegen.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/mips/lithium-gap-resolver-mips.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/mips64/lithium-gap-resolver-mips64.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/objects-inl.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/ppc/lithium-gap-resolver-ppc.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/preparser.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/regexp-macro-assembler-irregexp.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/regexp-macro-assembler-irregexp-inl.h View 1 chunk +2 lines, -7 lines 0 comments Download
M src/string-builder.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/typing.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/v8.h View 2 chunks +2 lines, -16 lines 1 comment Download
M src/x64/lithium-gap-resolver-x64.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/x87/lithium-gap-resolver-x87.h View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Michael Starzinger
PTAL all reviewers, I would like to get sign-of on the below steps (1)-(3) from ...
5 years, 4 months ago (2015-08-10 18:55:18 UTC) #2
titzer
On 2015/08/10 18:55:18, Michael Starzinger wrote: > PTAL all reviewers, I would like to get ...
5 years, 4 months ago (2015-08-10 19:02:33 UTC) #3
Hannes Payer (out of office)
lgtm
5 years, 4 months ago (2015-08-11 06:06:01 UTC) #4
Benedikt Meurer
Awesome. LGTM.
5 years, 4 months ago (2015-08-11 06:08:04 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1282503003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1282503003/1
5 years, 4 months ago (2015-08-11 07:32:26 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-11 07:34:16 UTC) #8
commit-bot: I haz the power
5 years, 4 months ago (2015-08-11 07:34:28 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/58109a2c5038fbbb208904d4edfc0a7a758928c3
Cr-Commit-Position: refs/heads/master@{#30102}

Powered by Google App Engine
This is Rietveld 408576698