Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(365)

Side by Side Diff: src/v8.h

Issue 1282503003: Remove several grab-bag includes from the v8.h header. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/typing.h ('k') | src/x64/lithium-gap-resolver-x64.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // 5 //
6 // Top include for all V8 .cc files. 6 // Top include for all V8 .cc files.
7 // 7 //
8 8
9 #ifndef V8_V8_H_ 9 #ifndef V8_V8_H_
10 #define V8_V8_H_ 10 #define V8_V8_H_
11 11
12 #if defined(GOOGLE3) || defined(DCHECK_ALWAYS_ON) 12 #if defined(GOOGLE3) || defined(DCHECK_ALWAYS_ON)
13 // Google3 and Chromium special flag handling. 13 // Google3 and Chromium special flag handling.
14 #if defined(DEBUG) && defined(NDEBUG) 14 #if defined(DEBUG) && defined(NDEBUG)
15 // V8 only uses DEBUG and whenever it is set we are building a debug 15 // V8 only uses DEBUG and whenever it is set we are building a debug
16 // version of V8. We do not use NDEBUG and simply undef it here for 16 // version of V8. We do not use NDEBUG and simply undef it here for
17 // consistency. 17 // consistency.
18 #undef NDEBUG 18 #undef NDEBUG
19 #endif 19 #endif
20 #endif // defined(GOOGLE3) 20 #endif // defined(GOOGLE3)
21 21
22 // V8 only uses DEBUG, but included external files 22 // V8 only uses DEBUG, but included external files
23 // may use NDEBUG - make sure they are consistent. 23 // may use NDEBUG - make sure they are consistent.
24 #if defined(DEBUG) && defined(NDEBUG) 24 #if defined(DEBUG) && defined(NDEBUG)
25 #error both DEBUG and NDEBUG are set 25 #error both DEBUG and NDEBUG are set
26 #endif 26 #endif
27 27
28 // Basic includes 28 // Basic includes
29 #include "include/v8.h" 29 #include "include/v8.h"
30 #include "include/v8-platform.h" 30 #include "src/allocation.h"
31 #include "src/checks.h" // NOLINT
32 #include "src/allocation.h" // NOLINT
33 #include "src/assert-scope.h" // NOLINT
34 #include "src/utils.h" // NOLINT
35 #include "src/flags.h" // NOLINT
36 #include "src/globals.h" // NOLINT
37 31
38 // Objects 32 // Objects
39 #include "src/objects-inl.h" // NOLINT 33 #include "src/objects-inl.h"
40 #include "src/log-inl.h" // NOLINT
41 #include "src/handles-inl.h" // NOLINT
42 #include "src/types-inl.h" // NOLINT
43 34
44 namespace v8 { 35 namespace v8 {
45 namespace internal { 36 namespace internal {
46 37
47 class V8 : public AllStatic { 38 class V8 : public AllStatic {
48 public: 39 public:
49 // Global actions. 40 // Global actions.
50 41
51 static bool Initialize(); 42 static bool Initialize();
52 static void TearDown(); 43 static void TearDown();
(...skipping 20 matching lines...) Expand all
73 static void SetSnapshotBlob(StartupData* snapshot_blob); 64 static void SetSnapshotBlob(StartupData* snapshot_blob);
74 65
75 private: 66 private:
76 static void InitializeOncePerProcessImpl(); 67 static void InitializeOncePerProcessImpl();
77 static void InitializeOncePerProcess(); 68 static void InitializeOncePerProcess();
78 69
79 // v8::Platform to use. 70 // v8::Platform to use.
80 static v8::Platform* platform_; 71 static v8::Platform* platform_;
81 }; 72 };
82 73
83
84 // JavaScript defines two kinds of 'nil'.
85 enum NilValue { kNullValue, kUndefinedValue };
Michael Starzinger 2015/08/10 18:55:18 Note that this has been moved to the globals.h fil
86
87
88 } } // namespace v8::internal 74 } } // namespace v8::internal
89 75
90 #endif // V8_V8_H_ 76 #endif // V8_V8_H_
OLDNEW
« no previous file with comments | « src/typing.h ('k') | src/x64/lithium-gap-resolver-x64.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698