Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(423)

Unified Diff: src/DEPS

Issue 1282503003: Remove several grab-bag includes from the v8.h header. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/accessors.h » ('j') | src/v8.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/DEPS
diff --git a/src/DEPS b/src/DEPS
index 021cd3bf2d94c0fece6769fc60111ee5c12d3b67..37becca773b8579577ed85ebde38feed5a79c0b2 100644
--- a/src/DEPS
+++ b/src/DEPS
@@ -13,6 +13,12 @@ include_rules = [
]
specific_include_rules = {
+ ".*\.h": [
+ # Note that src/v8.h is the top header for some .cc files, it shouldn't be
+ # included in any .h files though. In the long run we should make src/v8.h
+ # act like any normal header file, instead of a grab-bag include.
+ "-src/v8.h",
+ ],
"d8\.cc": [
"+include/libplatform/libplatform.h",
],
« no previous file with comments | « no previous file | src/accessors.h » ('j') | src/v8.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698