Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Unified Diff: src/v8.h

Issue 1282503003: Remove several grab-bag includes from the v8.h header. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/typing.h ('k') | src/x64/lithium-gap-resolver-x64.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/v8.h
diff --git a/src/v8.h b/src/v8.h
index c516cacdf8be0ff24719f3b73c9a5dca33b309d3..23e1a1230c893ce51d681590393b9a62dcef3c76 100644
--- a/src/v8.h
+++ b/src/v8.h
@@ -27,19 +27,10 @@
// Basic includes
#include "include/v8.h"
-#include "include/v8-platform.h"
-#include "src/checks.h" // NOLINT
-#include "src/allocation.h" // NOLINT
-#include "src/assert-scope.h" // NOLINT
-#include "src/utils.h" // NOLINT
-#include "src/flags.h" // NOLINT
-#include "src/globals.h" // NOLINT
+#include "src/allocation.h"
// Objects
-#include "src/objects-inl.h" // NOLINT
-#include "src/log-inl.h" // NOLINT
-#include "src/handles-inl.h" // NOLINT
-#include "src/types-inl.h" // NOLINT
+#include "src/objects-inl.h"
namespace v8 {
namespace internal {
@@ -80,11 +71,6 @@ class V8 : public AllStatic {
static v8::Platform* platform_;
};
-
-// JavaScript defines two kinds of 'nil'.
-enum NilValue { kNullValue, kUndefinedValue };
Michael Starzinger 2015/08/10 18:55:18 Note that this has been moved to the globals.h fil
-
-
} } // namespace v8::internal
#endif // V8_V8_H_
« no previous file with comments | « src/typing.h ('k') | src/x64/lithium-gap-resolver-x64.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698