Adding allocator annotations to blink classes and structs.

Adding allocator annotations to blink classes and structs.

Document about replacing:
https://docs.google.com/document/d/1e4OvVMFuPxtoLGr6VkAu7qTaHWS02qBv5ndQoW8v1Wg/edit

blink-dev thread:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/1YrpiUJ0etg

BUG=

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200693

[tasak, 2015-08-11 10:59:46]

Patchset #1 (id:1) has been deleted

[tasak, 2015-08-11 11:00:30]

Patchset #1 (id:20001) has been deleted

[tasak, 2015-08-12 07:39:38]

tasak@google.com changed reviewers:
+ haraken@chromium.org

[tasak, 2015-08-12 07:39:39]

Would you review this CL?

[haraken, 2015-08-12 07:56:12]

LGTM

Let's ping that blink-dev thread and mention we're about to land this. Also add
the link of the blink-dev thread to the CL description.

https://codereview.chromium.org/1278983003/diff/60001/Source/bindings/core/v8...
File Source/bindings/core/v8/ActiveDOMCallback.h (right):

https://codereview.chromium.org/1278983003/diff/60001/Source/bindings/core/v8...
Source/bindings/core/v8/ActiveDOMCallback.h:58: ActiveDOMCallback() = delete;

I'm just curious but why do we need this? (or how did you find you need this?)

https://codereview.chromium.org/1278983003/diff/60001/Source/bindings/core/v8...
File Source/bindings/core/v8/Dictionary.h (right):

https://codereview.chromium.org/1278983003/diff/60001/Source/bindings/core/v8...
Source/bindings/core/v8/Dictionary.h:114: STATIC_ONLY(DictionaryHelper);

Can we move this to the top of the class/struct declaration?

https://codereview.chromium.org/1278983003/diff/60001/Source/bindings/core/v8...
File Source/bindings/core/v8/Iterable.h (right):

https://codereview.chromium.org/1278983003/diff/60001/Source/bindings/core/v8...
Source/bindings/core/v8/Iterable.h:100: STATIC_ONLY(KeySelector);

Ditto.

https://codereview.chromium.org/1278983003/diff/60001/Source/bindings/core/v8...
File Source/bindings/core/v8/WrapperTypeInfo.h (right):

https://codereview.chromium.org/1278983003/diff/60001/Source/bindings/core/v8...
Source/bindings/core/v8/WrapperTypeInfo.h:208: DISALLOW_ALLOCATION();

Move this to the top of the class/struct declaration. The same comment for other
parts in this CL.

[tasak, 2015-08-12 09:13:26]

Thank you for review.

https://codereview.chromium.org/1278983003/diff/60001/Source/bindings/core/v8...
File Source/bindings/core/v8/ActiveDOMCallback.h (right):

https://codereview.chromium.org/1278983003/diff/60001/Source/bindings/core/v8...
Source/bindings/core/v8/ActiveDOMCallback.h:58: ActiveDOMCallback() = delete;
On 2015/08/12 07:56:12, haraken wrote:
> 
> I'm just curious but why do we need this? (or how did you find you need this?)

Not related to this CL. I would like to confirm that no body uses
"ActiveDOMCallback callback;" or something.

https://codereview.chromium.org/1278983003/diff/60001/Source/bindings/core/v8...
File Source/bindings/core/v8/Dictionary.h (right):

https://codereview.chromium.org/1278983003/diff/60001/Source/bindings/core/v8...
Source/bindings/core/v8/Dictionary.h:114: STATIC_ONLY(DictionaryHelper);
On 2015/08/12 07:56:12, haraken wrote:
> 
> Can we move this to the top of the class/struct declaration?

Done.

https://codereview.chromium.org/1278983003/diff/60001/Source/bindings/core/v8...
File Source/bindings/core/v8/Iterable.h (right):

https://codereview.chromium.org/1278983003/diff/60001/Source/bindings/core/v8...
Source/bindings/core/v8/Iterable.h:100: STATIC_ONLY(KeySelector);
On 2015/08/12 07:56:12, haraken wrote:
> 
> Ditto.

Done.

https://codereview.chromium.org/1278983003/diff/60001/Source/bindings/core/v8...
File Source/bindings/core/v8/WrapperTypeInfo.h (right):

https://codereview.chromium.org/1278983003/diff/60001/Source/bindings/core/v8...
Source/bindings/core/v8/WrapperTypeInfo.h:208: DISALLOW_ALLOCATION();
On 2015/08/12 07:56:12, haraken wrote:
> 
> Move this to the top of the class/struct declaration. The same comment for
other
> parts in this CL.

Done.

[tasak, 2015-08-12 09:13:32]

The CQ bit was checked by tasak@google.com

[tasak, 2015-08-12 09:13:33]

The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/1278983003/#ps80001
(title: " ")

[commit-bot: I haz the power, 2015-08-12 09:13:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1278983003/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1278983003/80001

[tasak, 2015-08-12 09:25:51]

The CQ bit was unchecked by tasak@google.com

[tasak, 2015-08-13 10:23:17]

The CQ bit was checked by tasak@google.com

[commit-bot: I haz the power, 2015-08-13 10:23:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1278983003/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1278983003/80001

[commit-bot: I haz the power, 2015-08-13 11:31:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-13 11:31:30]

Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[tasak, 2015-08-18 02:45:32]

The CQ bit was checked by tasak@google.com

[tasak, 2015-08-18 02:45:33]

The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/1278983003/#ps100001
(title: "Fixed patch conflict")

[commit-bot: I haz the power, 2015-08-18 02:45:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1278983003/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1278983003/100001

[commit-bot: I haz the power, 2015-08-18 04:33:03]

Committed patchset #4 (id:100001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200693

[Mostyn Bramley-Moore, 2015-08-18 19:55:07]

This seems to have broken gcc builds.  

Example error from gcc 4.8.4:
In file included from
gen/blink/bindings/core/v8/V8GeneratedCoreBindings01.cpp:32:0:
gen/blink/bindings/core/v8/V8DOMMatrixReadOnly.cpp:647:1: error: could not
convert '{"a", blink::DOMMatrixReadOnlyV8Internal::aAttributeGetterCallback, 0,
0, 0, 0, DEFAULT, (v8::PropertyAttribute)0u, ExposedToAllScripts, OnPrototype,
CheckHolder}' from '<brace-enclosed initializer list>' to
'blink::V8DOMConfiguration::AccessorConfiguration'

[tasak, 2015-08-20 03:38:05]

On 2015/08/18 19:55:07, Mostyn Bramley-Moore wrote:
> This seems to have broken gcc builds.  
> 
> Example error from gcc 4.8.4:
> In file included from
> gen/blink/bindings/core/v8/V8GeneratedCoreBindings01.cpp:32:0:
> gen/blink/bindings/core/v8/V8DOMMatrixReadOnly.cpp:647:1: error: could not
> convert '{"a", blink::DOMMatrixReadOnlyV8Internal::aAttributeGetterCallback,
0,
> 0, 0, 0, DEFAULT, (v8::PropertyAttribute)0u, ExposedToAllScripts, OnPrototype,
> CheckHolder}' from '<brace-enclosed initializer list>' to
> 'blink::V8DOMConfiguration::AccessorConfiguration'

Thank you for notification.
I created a fixing patch: https://codereview.chromium.org/1307503002/