Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(352)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1269623004: [NaCl SDK] Remove support for bionic toolchain (Closed)

Created:
5 years, 4 months ago by Sam Clegg
Modified:
5 years ago
Reviewers:
binji
CC:
binji+watch_chromium.org, chromium-reviews, native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[NaCl SDK] Remove support for bionic toolchain CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_nacl_sdk;tryserver.chromium.mac:mac_nacl_sdk;tryserver.chromium.win:win_nacl_sdk Committed: https://crrev.com/2bd1f02649d6fe8b0a5616932e40b67478c58174 Cr-Commit-Position: refs/heads/master@{#362454}

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -847 lines) Patch
M native_client_sdk/src/BUILDING.rst View 1 chunk +2 lines, -2 lines 0 comments Download
M native_client_sdk/src/build_tools/build_projects.py View 4 chunks +0 lines, -9 lines 0 comments Download
M native_client_sdk/src/build_tools/build_sdk.py View 1 2 13 chunks +6 lines, -69 lines 0 comments Download
M native_client_sdk/src/build_tools/buildbot_common.py View 1 chunk +2 lines, -2 lines 0 comments Download
M native_client_sdk/src/build_tools/buildbot_run.py View 2 chunks +0 lines, -7 lines 0 comments Download
M native_client_sdk/src/build_tools/json/naclsdk_manifest2.json View 1 2 1 chunk +0 lines, -10 lines 0 comments Download
M native_client_sdk/src/build_tools/parse_dsc.py View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M native_client_sdk/src/build_tools/tests/update_nacl_manifest_test.py View 1 5 chunks +1 line, -25 lines 0 comments Download
M native_client_sdk/src/build_tools/update_nacl_manifest.py View 1 6 chunks +4 lines, -22 lines 0 comments Download
M native_client_sdk/src/doc/sdk/download.rst View 1 2 chunks +0 lines, -2 lines 0 comments Download
M native_client_sdk/src/examples/demo/nacl_io_demo/example.dsc View 1 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/libraries/nacl_io/jsfs/js_fs_node.cc View 1 chunk +1 line, -2 lines 0 comments Download
D native_client_sdk/src/libraries/nacl_io/kernel_wrap_bionic.cc View 1 1 chunk +0 lines, -502 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/library.dsc View 1 2 chunks +1 line, -2 lines 0 comments Download
M native_client_sdk/src/libraries/ppapi_simple/library.dsc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/libraries/ppapi_simple_cpp/library.dsc View 1 2 1 chunk +1 line, -1 line 0 comments Download
D native_client_sdk/src/libraries/ppapi_stub/library.dsc View 1 chunk +0 lines, -19 lines 0 comments Download
D native_client_sdk/src/libraries/ppapi_stub/main.c View 1 chunk +0 lines, -17 lines 0 comments Download
D native_client_sdk/src/libraries/ppapi_stub/ppapi_main.c View 1 chunk +0 lines, -110 lines 0 comments Download
M native_client_sdk/src/resources/Makefile.library.template View 1 2 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/tests/nacl_io_test/example.dsc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/tools/common.mk View 1 2 chunks +1 line, -5 lines 0 comments Download
M native_client_sdk/src/tools/create_nmf.py View 1 2 1 chunk +0 lines, -7 lines 0 comments Download
M native_client_sdk/src/tools/lib/get_shared_deps.py View 1 2 1 chunk +3 lines, -10 lines 0 comments Download
M native_client_sdk/src/tools/nacl_gcc.mk View 1 2 5 chunks +2 lines, -19 lines 0 comments Download

Messages

Total messages: 23 (9 generated)
Sam Clegg
Not ready to pull the trigger just yet, but here it is.
5 years, 4 months ago (2015-08-04 19:37:05 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1269623004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1269623004/20001
5 years, 2 months ago (2015-10-06 22:09:40 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-10-07 01:35:22 UTC) #6
binji
lgtm https://codereview.chromium.org/1269623004/diff/20001/native_client_sdk/src/build_tools/build_sdk.py File native_client_sdk/src/build_tools/build_sdk.py (left): https://codereview.chromium.org/1269623004/diff/20001/native_client_sdk/src/build_tools/build_sdk.py#oldcode942 native_client_sdk/src/build_tools/build_sdk.py:942: toolchain_build = None this line still needed?
5 years, 2 months ago (2015-10-08 17:24:23 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1269623004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1269623004/40001
5 years ago (2015-11-30 23:42:28 UTC) #9
Sam Clegg
https://codereview.chromium.org/1269623004/diff/20001/native_client_sdk/src/build_tools/build_sdk.py File native_client_sdk/src/build_tools/build_sdk.py (left): https://codereview.chromium.org/1269623004/diff/20001/native_client_sdk/src/build_tools/build_sdk.py#oldcode942 native_client_sdk/src/build_tools/build_sdk.py:942: toolchain_build = None On 2015/10/08 17:24:23, binji wrote: > ...
5 years ago (2015-12-01 00:18:05 UTC) #10
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-12-01 02:38:33 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1269623004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1269623004/40001
5 years ago (2015-12-01 18:20:36 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years ago (2015-12-01 18:27:14 UTC) #17
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/2bd1f02649d6fe8b0a5616932e40b67478c58174 Cr-Commit-Position: refs/heads/master@{#362454}
5 years ago (2015-12-01 18:28:06 UTC) #19
scheib
A revert of this CL (patchset #3 id:40001) has been created in https://codereview.chromium.org/1493443002/ by scheib@chromium.org. ...
5 years ago (2015-12-01 19:38:52 UTC) #20
Sam Clegg
On 2015/12/01 19:38:52, scheib wrote: > A revert of this CL (patchset #3 id:40001) has ...
5 years ago (2015-12-01 19:40:02 UTC) #21
gab
A revert of this CL (patchset #3 id:40001) has been created in https://codereview.chromium.org/1486003004/ by gab@chromium.org. ...
5 years ago (2015-12-01 20:01:30 UTC) #22
gab
5 years ago (2015-12-01 20:04:12 UTC) #23
Message was sent while issue was closed. 
On 2015/12/01 20:01:30, gab wrote:
> A revert of this CL (patchset #3 id:40001) has been created in
> https://codereview.chromium.org/1486003004/ by
https://mail.google.com/mail/?view=cm&fs=1&tf=1&to=gab@chromium.org.
> 
> The reason for reverting is: Breaks Linux x64 compile:
> https://build.chromium.org/p/chromium/builders/Linux%20x64
> 
> 
> Log:
> ninja: error:
> '../../native_client_sdk/src/libraries/nacl_io/kernel_wrap_bionic.cc', needed
by
>
'newlib_pnacl/obj/native_client_sdk/src/libraries/nacl_io/nacl_io/kernel_wrap_bionic.o',
> missing and no known rule to make it
> .

Oops sorry, missed traffic at bottom of this CL. Will hold off revert for now.

Powered by Google App Engine
This is Rietveld 408576698