Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 1493443002: Revert of [NaCl SDK] Remove support for bionic toolchain (Closed)

Created:
5 years ago by scheib
Modified:
5 years ago
Reviewers:
binji, Sam Clegg
CC:
binji+watch_chromium.org, chromium-reviews, native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [NaCl SDK] Remove support for bionic toolchain (patchset #3 id:40001 of https://codereview.chromium.org/1269623004/ ) Reason for revert: Broke build: https://build.chromium.org/p/chromium/builders/Linux%20x64/builds/12371 ninja -w dupbuild=err -C /b/build/slave/Linux_x64/build/src/out/Release chrome gn_all -j50 ninja: Entering directory `/b/build/slave/Linux_x64/build/src/out/Release' [1/1] Regenerating ninja files ninja: error: '../../native_client_sdk/src/libraries/nacl_io/kernel_wrap_bionic.cc', needed by 'newlib_pnacl/obj/native_client_sdk/src/libraries/nacl_io/nacl_io/kernel_wrap_bionic.o', missing and no known rule to make it Original issue's description: > [NaCl SDK] Remove support for bionic toolchain > > CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_nacl_sdk;tryserver.chromium.mac:mac_nacl_sdk;tryserver.chromium.win:win_nacl_sdk > > Committed: https://crrev.com/2bd1f02649d6fe8b0a5616932e40b67478c58174 > Cr-Commit-Position: refs/heads/master@{#362454} TBR=binji@chromium.org,sbc@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/734ad4386e305c7e7abfc5731bfd82692625b887 Cr-Commit-Position: refs/heads/master@{#362480}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+847 lines, -28 lines) Patch
M native_client_sdk/src/BUILDING.rst View 1 chunk +2 lines, -2 lines 0 comments Download
M native_client_sdk/src/build_tools/build_projects.py View 4 chunks +9 lines, -0 lines 0 comments Download
M native_client_sdk/src/build_tools/build_sdk.py View 13 chunks +69 lines, -6 lines 0 comments Download
M native_client_sdk/src/build_tools/buildbot_common.py View 1 chunk +2 lines, -2 lines 0 comments Download
M native_client_sdk/src/build_tools/buildbot_run.py View 2 chunks +7 lines, -0 lines 0 comments Download
M native_client_sdk/src/build_tools/json/naclsdk_manifest2.json View 1 chunk +10 lines, -0 lines 0 comments Download
M native_client_sdk/src/build_tools/parse_dsc.py View 1 chunk +1 line, -0 lines 0 comments Download
M native_client_sdk/src/build_tools/tests/update_nacl_manifest_test.py View 5 chunks +25 lines, -1 line 0 comments Download
M native_client_sdk/src/build_tools/update_nacl_manifest.py View 6 chunks +22 lines, -4 lines 0 comments Download
M native_client_sdk/src/doc/sdk/download.rst View 2 chunks +2 lines, -0 lines 0 comments Download
M native_client_sdk/src/examples/demo/nacl_io_demo/example.dsc View 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/libraries/nacl_io/jsfs/js_fs_node.cc View 1 chunk +2 lines, -1 line 0 comments Download
A native_client_sdk/src/libraries/nacl_io/kernel_wrap_bionic.cc View 1 chunk +502 lines, -0 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/library.dsc View 2 chunks +2 lines, -1 line 0 comments Download
M native_client_sdk/src/libraries/ppapi_simple/library.dsc View 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/libraries/ppapi_simple_cpp/library.dsc View 1 chunk +1 line, -1 line 0 comments Download
A native_client_sdk/src/libraries/ppapi_stub/library.dsc View 1 chunk +19 lines, -0 lines 0 comments Download
A native_client_sdk/src/libraries/ppapi_stub/main.c View 1 chunk +17 lines, -0 lines 0 comments Download
A native_client_sdk/src/libraries/ppapi_stub/ppapi_main.c View 1 chunk +110 lines, -0 lines 0 comments Download
M native_client_sdk/src/resources/Makefile.library.template View 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/tests/nacl_io_test/example.dsc View 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/tools/common.mk View 2 chunks +5 lines, -1 line 0 comments Download
M native_client_sdk/src/tools/create_nmf.py View 1 chunk +7 lines, -0 lines 0 comments Download
M native_client_sdk/src/tools/lib/get_shared_deps.py View 1 chunk +10 lines, -3 lines 0 comments Download
M native_client_sdk/src/tools/nacl_gcc.mk View 5 chunks +19 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
scheib
Created Revert of [NaCl SDK] Remove support for bionic toolchain
5 years ago (2015-12-01 19:38:53 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1493443002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1493443002/1
5 years ago (2015-12-01 19:39:22 UTC) #2
Sam Clegg
On 2015/12/01 19:39:22, commit-bot: I haz the power wrote: > CQ is trying da patch. ...
5 years ago (2015-12-01 19:40:32 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-01 19:41:44 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/734ad4386e305c7e7abfc5731bfd82692625b887 Cr-Commit-Position: refs/heads/master@{#362480}
5 years ago (2015-12-01 19:42:40 UTC) #7
scheib
On 2015/12/01 19:40:32, Sam Clegg wrote: > On 2015/12/01 19:39:22, commit-bot: I haz the power ...
5 years ago (2015-12-01 19:45:55 UTC) #8
Sam Clegg
5 years ago (2015-12-01 19:48:11 UTC) #9
Message was sent while issue was closed.
On 2015/12/01 19:45:55, scheib wrote:
> On 2015/12/01 19:40:32, Sam Clegg wrote:
> > On 2015/12/01 19:39:22, commit-bot: I haz the power wrote:
> > > CQ is trying da patch. Follow status at
> > >  https://chromium-cq-status.appspot.com/patch-status/1493443002/1
> > > View timeline at
> > >  https://chromium-cq-status.appspot.com/patch-timeline/1493443002/1
> > 
> > A fix is already in flight: https://codereview.chromium.org/1489103002/
> 
> Didn't see that in #chromium, and policy is revert and reland
> https://www.chromium.org/developers/tree-sheriffs

No probs.

Powered by Google App Engine
This is Rietveld 408576698