Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Unified Diff: native_client_sdk/src/build_tools/build_projects.py

Issue 1269623004: [NaCl SDK] Remove support for bionic toolchain (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « native_client_sdk/src/BUILDING.rst ('k') | native_client_sdk/src/build_tools/build_sdk.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: native_client_sdk/src/build_tools/build_projects.py
diff --git a/native_client_sdk/src/build_tools/build_projects.py b/native_client_sdk/src/build_tools/build_projects.py
index 0c5077a6534d24ae760dbdd43c8903d19794c0c8..f1a76c23686687c97db0e02fc936c17fbfea722f 100755
--- a/native_client_sdk/src/build_tools/build_projects.py
+++ b/native_client_sdk/src/build_tools/build_projects.py
@@ -30,7 +30,6 @@ LIB_DICT = {
'win': ['x86_32']
}
VALID_TOOLCHAINS = [
- 'bionic',
'newlib',
'clang-newlib',
'glibc',
@@ -213,10 +212,6 @@ def BuildProjectsBranch(pepperdir, branch, deps, clean, config, args=None):
make_cmd = [make, '-j', jobs]
make_cmd.append('CONFIG='+config)
- # We always ENABLE_BIONIC in case we need it. If neither --bionic nor
- # -t bionic have been provided on the command line, then VALID_TOOLCHAINS
- # will not contain a bionic target.
- make_cmd.append('ENABLE_BIONIC=1')
if not deps:
make_cmd.append('IGNORE_DEPS=1')
@@ -256,8 +251,6 @@ def main(args):
parser.add_argument('--config',
help='Choose configuration to build (Debug or Release). Builds both '
'by default')
- parser.add_argument('--bionic',
- help='Enable bionic projects', action='store_true')
parser.add_argument('-x', '--experimental',
help='Build experimental projects', action='store_true')
parser.add_argument('-t', '--toolchain',
@@ -301,8 +294,6 @@ def main(args):
# e.g. If an example supports newlib and glibc, then the default will be
# newlib.
options.toolchain = ['pnacl', 'newlib', 'glibc', 'host', 'clang-newlib']
- if options.experimental or options.bionic:
- options.toolchain.append('bionic')
if 'host' in options.toolchain:
options.toolchain.remove('host')
« no previous file with comments | « native_client_sdk/src/BUILDING.rst ('k') | native_client_sdk/src/build_tools/build_sdk.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698