native_client_sdk/src/build_tools/buildbot_run.py - Issue 1269623004: [NaCl SDK] Remove support for bionic toolchain

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: native_client_sdk/src/build_tools/buildbot_run.py

Issue 1269623004: [NaCl SDK] Remove support for bionic toolchain (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: native_client_sdk/src/build_tools/buildbot_run.py

diff --git a/native_client_sdk/src/build_tools/buildbot_run.py b/native_client_sdk/src/build_tools/buildbot_run.py

index 5971a58c1647c36a2a851a979d4b0ba0bee38fc5..f6e4ee79d2137fb8739e88fd713ca010693195fe 100755

--- a/native_client_sdk/src/build_tools/buildbot_run.py

+++ b/native_client_sdk/src/build_tools/buildbot_run.py

@@ -63,8 +63,6 @@ def StepBuildSDK():

new_script_dir = SCRIPT_DIR

args = [sys.executable, 'build_sdk.py']

- if 'bionic' in os.getenv('BUILDBOT_BUILDERNAME', ''):

- args.append('--bionic')

try:

Run(args, cwd=new_script_dir)

@@ -87,11 +85,6 @@ def StepTestSDK():

])

cmd.extend([sys.executable, 'test_sdk.py'])

- # TODO(noelallen): crbug 386332

- # For Bionic SDK, only build do a build test until we have hardware.

- if 'bionic' in os.getenv('BUILDBOT_BUILDERNAME', ''):

- cmd.extend(['build_examples', 'copy_tests', 'build_tests'])

Run(cmd, cwd=SCRIPT_DIR)