Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1265983003: Address some SkLightingShader TODOs (Closed)

Created:
5 years, 4 months ago by robertphillips
Modified:
5 years, 4 months ago
Reviewers:
jvanverth1, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Address some SkLightingShader TODOs This CL: switches the light colors to be 3 scalars (SkColor3f) adds some dox Committed: https://skia.googlesource.com/skia/+/a9652ac09ee45b964e0d906887e1521ee328cb6a

Patch Set 1 #

Patch Set 2 : Fix type #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -63 lines) Patch
M gm/lightingshader.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M include/effects/SkPoint3.h View 1 chunk +1 line, -0 lines 0 comments Download
M samplecode/SampleLighting.cpp View 3 chunks +10 lines, -7 lines 0 comments Download
M src/effects/SkLightingShader.h View 2 chunks +15 lines, -3 lines 0 comments Download
M src/effects/SkLightingShader.cpp View 1 17 chunks +45 lines, -50 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
robertphillips
5 years, 4 months ago (2015-07-30 17:21:53 UTC) #2
reed1
lgtm
5 years, 4 months ago (2015-07-30 18:24:19 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1265983003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1265983003/20001
5 years, 4 months ago (2015-07-30 18:45:33 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 4 months ago (2015-07-30 19:00:10 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1265983003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1265983003/20001
5 years, 4 months ago (2015-07-31 12:16:50 UTC) #9
commit-bot: I haz the power
5 years, 4 months ago (2015-07-31 12:17:30 UTC) #10
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/a9652ac09ee45b964e0d906887e1521ee328cb6a

Powered by Google App Engine
This is Rietveld 408576698